From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH 1/2] vfio/ccw: allocate irq info with the right size Date: Tue, 18 Jul 2017 10:32:13 +0200 Message-ID: <20170718103213.29a597b2@gondolin> References: <20170718014926.44781-1-bjsdjshi@linux.vnet.ibm.com> <20170718014926.44781-2-bjsdjshi@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, borntraeger@de.ibm.com, Jing Zhang To: Dong Jia Shi Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55438 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbdGRIcR (ORCPT ); Tue, 18 Jul 2017 04:32:17 -0400 In-Reply-To: <20170718014926.44781-2-bjsdjshi@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 18 Jul 2017 03:49:25 +0200 Dong Jia Shi wrote: > From: Jing Zhang > > When allocating memory for the vfio_irq_info parameter of the > VFIO_DEVICE_GET_IRQ_INFO ioctl, we used the wrong size. Let's > fix it by using the right size. > > Reviewed-by: Dong Jia Shi > Signed-off-by: Jing Zhang > Signed-off-by: Dong Jia Shi > --- > hw/vfio/ccw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c > index 12d0262336..8d97b53e77 100644 > --- a/hw/vfio/ccw.c > +++ b/hw/vfio/ccw.c > @@ -168,7 +168,7 @@ static void vfio_ccw_register_io_notifier(VFIOCCWDevice *vcdev, Error **errp) > return; > } > > - argsz = sizeof(*irq_set); > + argsz = sizeof(*irq_info); > irq_info = g_malloc0(argsz); > irq_info->index = VFIO_CCW_IO_IRQ_INDEX; > irq_info->argsz = argsz; irq_set is larger than irq_info, but yes, let's do this correctly. Out of curiosity, how did you spot this?