From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: x86@kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 6/8] x86: add MULTIUSER dependency for KVM
Date: Wed, 19 Jul 2017 16:11:53 +0200 [thread overview]
Message-ID: <20170719141153.GA17303@potion> (raw)
In-Reply-To: <20170719125310.2487451-7-arnd@arndb.de>
2017-07-19 14:53+0200, Arnd Bergmann:
> KVM tries to select 'TASKSTATS', which had additional dependencies:
>
> warning: (KVM) selects TASKSTATS which has unmet direct dependencies (NET && MULTIUSER)
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Hm, do you know why Kconfig warns instead of propagating the
dependencies?
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> @@ -22,7 +22,7 @@ config KVM
> # for TASKSTATS/TASK_DELAY_ACCT:
> - depends on NET
> + depends on NET && MULTIUSER
The current condition goes halfway to nowhere, so the patch is
definitely an improvement, even if the result is not good ...
Applied, thanks.
next prev parent reply other threads:[~2017-07-19 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170719125310.2487451-1-arnd@arndb.de>
2017-07-19 12:53 ` [PATCH 6/8] x86: add MULTIUSER dependency for KVM Arnd Bergmann
2017-07-19 14:11 ` Radim Krčmář [this message]
2017-07-19 14:18 ` Arnd Bergmann
2017-07-19 16:13 ` Radim Krčmář
2017-07-23 13:41 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719141153.GA17303@potion \
--to=rkrcmar@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox