public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Ladi Prosek <lprosek@redhat.com>
Cc: KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: hyperv: support HV_X64_MSR_TSC_FREQUENCY and HV_X64_MSR_APIC_FREQUENCY
Date: Wed, 26 Jul 2017 14:45:59 +0200	[thread overview]
Message-ID: <20170726124558.GE2544@flask> (raw)
In-Reply-To: <CABdb7361cbCRkaZQu=m0sRzgY=QT+enLjc=X2qADsGZhbBXZHg@mail.gmail.com>

2017-07-26 11:47+0200, Ladi Prosek:
> On Mon, Jul 24, 2017 at 4:23 PM, Radim Krčmář <rkrcmar@redhat.com> wrote:
> > 2017-07-17 15:28+0200, Ladi Prosek:
> >> The newly supported MSRs are advertised with the AccessFrequencyRegs
> >> partition privilege flag and CPUID.40000003H:EDX[8] "Support for
> >> determining timer frequencies is available" (both outside of the scope of
> >> this KVM patch).
> >
> > Do Windows ignore the AccessFrequencyMsrs (CPUID.40000003H:EAX[11]) bit?
> 
> No, Windows won't read the MSRs without CPUID.40000003H:EAX[11]. The
> other bit (CPUID.40000003H:EDX[8]) appears to be ignored, or at least
> I couldn't find any difference in behavior.

Looking more into it, we are emulating non-root partitions, where
CPUID.40000003H:EDX[8] would probably be clear and then the check Linux
has in ms_hyperv_init_platform() could be wrong.  I am not sure what
FrequencyMsrsAvailable is for, though -- to allow AccessFrequencyMsrs in
non-root even if root has AccessFrequencyMsrs disabled?

> I wonder why you're asking, i.e. what is it that I'm misunderstanding :)

I was just curious why you didn't mention both in the same way
(CamelCase name or CPUID bit) and the best explanation was that you
didn't need to care about one, because Windows worked without it. :)
I think you got it all right.

Thanks.

  reply	other threads:[~2017-07-26 12:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 13:28 [PATCH] KVM: hyperv: support HV_X64_MSR_TSC_FREQUENCY and HV_X64_MSR_APIC_FREQUENCY Ladi Prosek
2017-07-24 14:23 ` Radim Krčmář
2017-07-26  9:47   ` Ladi Prosek
2017-07-26 12:45     ` Radim Krčmář [this message]
2017-07-24 17:48 ` Paolo Bonzini
2017-07-26  9:51   ` Ladi Prosek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170726124558.GE2544@flask \
    --to=rkrcmar@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lprosek@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox