From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH kvm-unit-tests] scripts: ShellCheck found cleanups Date: Wed, 26 Jul 2017 15:47:23 +0200 Message-ID: <20170726134722.GB2551@flask> References: <20170726132137.14722-1-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: kvm@vger.kernel.org, pbonzini@redhat.com To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44682 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751481AbdGZNr0 (ORCPT ); Wed, 26 Jul 2017 09:47:26 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 342548B120 for ; Wed, 26 Jul 2017 13:47:26 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170726132137.14722-1-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2017-07-26 15:21+0200, Andrew Jones: > Checked all the bash scripts with > > shellcheck --shell=bash > > checking with and without the following exclude list > > --exclude=SC1091,SC2004,SC2006,SC2086,SC2143,SC2155 > > Even with the exclude list there were some warnings not fixed with > this patch, but those are OK. > > Signed-off-by: Andrew Jones > --- I'll remember to never use -a in `test`, Reviewed-by: Radim Krčmář