From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cornelia Huck <cohuck@redhat.com>
Subject: Re: [PATCH v2 1/4] KVM: add spinlock optimization framework
Date: Tue, 8 Aug 2017 09:43:32 +0200
Message-ID: <20170808094332.25dc10ef@gondolin>
References: <1502165135-4784-1-git-send-email-longpeng2@huawei.com>
        <1502165135-4784-2-git-send-email-longpeng2@huawei.com>
        <d0b4f5ee-205e-f711-3b85-9023ca20b5b4@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "Longpeng(Mike)" <longpeng2@huawei.com>, rkrcmar@redhat.com,
        agraf@suse.com, borntraeger@de.ibm.com,
        christoffer.dall@linaro.org, marc.zyngier@arm.com,
        james.hogan@imgtec.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, weidong.huang@huawei.com,
        arei.gonglei@huawei.com, wangxinxin.wang@huawei.com,
        longpeng.mike@gmail.com, david@redhat.com
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <d0b4f5ee-205e-f711-3b85-9023ca20b5b4@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Tue, 8 Aug 2017 09:34:14 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 08/08/2017 06:05, Longpeng(Mike) wrote:
> >  	return 1;
> > diff --git a/arch/s390/kvm/diag.c b/arch/s390/kvm/diag.c
> > index ce865bd..4ea8c38 100644
> > --- a/arch/s390/kvm/diag.c
> > +++ b/arch/s390/kvm/diag.c
> > @@ -150,7 +150,7 @@ static int __diag_time_slice_end(struct kvm_vcpu *vcpu)
> >  {
> >  	VCPU_EVENT(vcpu, 5, "%s", "diag time slice end");
> >  	vcpu->stat.diagnose_44++;
> > -	kvm_vcpu_on_spin(vcpu);
> > +	kvm_vcpu_on_spin(vcpu, kvm_arch_vcpu_in_kernel(vcpu));
> >  	return 0;
> >  }
> >    
> 
> IIUC, diag is a privileged instruction so this an also be "true".
> 
> Paolo

Yes, indeed.