From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH v1 00/13] KVM x86/VMX cleanups Date: Thu, 10 Aug 2017 19:58:48 +0200 Message-ID: <20170810175847.GC22461@flask> References: <20170804131428.15844-1-david@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: kvm@vger.kernel.org, Paolo Bonzini To: David Hildenbrand Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59049 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbdHJR6x (ORCPT ); Thu, 10 Aug 2017 13:58:53 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B00D01AA639 for ; Thu, 10 Aug 2017 17:58:53 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170804131428.15844-1-david@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2017-08-04 15:14+0200, David Hildenbrand: > Some cleanups discovered while digging through the code. > > David Hildenbrand (13): > KVM: x86: mmu: returning void in a void function is strange > KVM: x86: mmu: use for_each_shadow_entry_lockless() > KVM: x86: mmu: free_page can handle NULL > KVM: x86: drop BUG_ON(vcpu->kvm) > KVM: VMX: vmx_vcpu_setup() cannot fail > KVM: x86: no need to inititalize vcpu members to 0 > KVM: VMX: drop enable_ept check from ept_sync_context() > KVM: VMX: call ept_sync_global() with enable_ept only > KVM: VMX: drop unnecessary function declarations > KVM: nVMX: no need to set vcpu->cpu when switching vmcs > KVM: VMX: cleanup init_rmode_identity_map() > KVM: x86: document special identity map address value > KVM: x86: allow setting identity map addr with no vcpus only > > Documentation/virtual/kvm/api.txt | 4 ++++ > arch/x86/kvm/mmu.c | 26 ++++++++------------ > arch/x86/kvm/vmx.c | 50 ++++++++++----------------------------- > arch/x86/kvm/x86.c | 21 +++++++--------- > 4 files changed, 35 insertions(+), 66 deletions(-) Nice cleanup, Reviewed-by: Radim Krčmář