From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH] KVM/VMX: Avoid CR3 VMEXIT during guest real mode when
 "unrestricted guest" is supported.
Date: Wed, 16 Aug 2017 15:26:29 +0200
Message-ID: <20170816132625.GD5975@flask>
References: <1502848704-7474-1-git-send-email-tianyu.lan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com,
        hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
To: Lan Tianyu <tianyu.lan@intel.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1502848704-7474-1-git-send-email-tianyu.lan@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

2017-08-15 21:58-0400, Lan Tianyu:
> These CR3 VMEXITs was introduced for platform without "unrestricted guest"
> support. This is to set ept identity table to guest CR3 in guest real
> mode because these platforms don't support ept real mode(CR0.PE and CR0.PG
> must be set to 1). But these VMEXITs is redundant for platforms with
> "unrestricted guest" support.
> 
> Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
> ---
>  arch/x86/kvm/vmx.c | 22 +++++++++++++---------
>  1 file changed, 13 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> @@ -4311,7 +4313,9 @@ static void vmx_set_cr3(struct kvm_vcpu *vcpu, unsigned long cr3)
>  	}
>  
>  	vmx_flush_tlb(vcpu);
> -	vmcs_writel(GUEST_CR3, guest_cr3);
> +
> +	if (!enable_unrestricted_guest || !enable_ept)
> +		vmcs_writel(GUEST_CR3, guest_cr3);

This looks wrong -- it would prevent update GUEST_CR3 outside of
non-root mode with enable_unrestricted_guest.