From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: David Hildenbrand <david@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
wanpeng.li@hotmail.com, Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [PATCH 2/3] KVM: x86: Avoid guest page table walk when gpa_available is set
Date: Fri, 18 Aug 2017 14:40:47 +0200 [thread overview]
Message-ID: <20170818124047.GC20100@flask> (raw)
In-Reply-To: <661ca6b5-bfb4-5377-d537-fb058d86ca0c@redhat.com>
2017-08-18 14:37+0200, Paolo Bonzini:
> On 18/08/2017 14:36, Radim Krčmář wrote:
> >>> + gpa = vcpu->arch.gpa_val;
> >>> + ret = vcpu_is_mmio_gpa(vcpu, addr, gpa, write);
> >>> + } else {
> >>> + ret = vcpu_mmio_gva_to_gpa(vcpu, addr, &gpa, exception, write);
> >>> }
> >>>
> >>> - ret = vcpu_mmio_gva_to_gpa(vcpu, addr, &gpa, exception, write);
> >>> -
> >>> if (ret < 0)
> >>> return X86EMUL_PROPAGATE_FAULT;
> >> just wondering if it makes sense to move this into the else branch (as
> >> it logically only belongs to vcpu_mmio_gva_to_gpa)
> >
> > It does, I took the liberty to change that.
>
> It was on purpose, but it's okay either way. :)
Oh, sorry, I was thinking that vcpu_is_mmio_gpa() should return bool. :)
next prev parent reply other threads:[~2017-08-18 12:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 16:36 [PATCH v2 0/3] KVM: MMU: pending MMU and nEPT patches Paolo Bonzini
2017-08-17 16:36 ` [PATCH 1/3] KVM: x86: simplify ept_misconfig Paolo Bonzini
2017-08-18 7:51 ` David Hildenbrand
2017-08-17 16:36 ` [PATCH 2/3] KVM: x86: Avoid guest page table walk when gpa_available is set Paolo Bonzini
2017-08-18 7:57 ` David Hildenbrand
2017-08-18 12:36 ` Radim Krčmář
2017-08-18 12:37 ` Paolo Bonzini
2017-08-18 12:40 ` Radim Krčmář [this message]
2017-08-17 16:36 ` [PATCH 3/3] KVM: x86: fix use of L1 MMIO areas in nested guests Paolo Bonzini
2017-08-18 7:59 ` David Hildenbrand
2017-08-18 12:35 ` Radim Krčmář
2017-08-18 12:38 ` Paolo Bonzini
2019-02-05 19:54 ` Jim Mattson
-- strict thread matches above, loose matches on Subject: below --
2017-08-11 16:52 [PATCH 0/3] KVM: MMU: pending MMU and nEPT patches Paolo Bonzini
2017-08-11 16:52 ` [PATCH 2/3] KVM: x86: Avoid guest page table walk when gpa_available is set Paolo Bonzini
2017-08-12 23:32 ` Wanpeng Li
2017-08-17 7:58 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818124047.GC20100@flask \
--to=rkrcmar@redhat.com \
--cc=brijesh.singh@amd.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).