From: Cornelia Huck <cohuck@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH 2/2] KVM: s390: sthyi: fix specification exception detection
Date: Mon, 21 Aug 2017 15:09:18 +0200 [thread overview]
Message-ID: <20170821150918.4df5d2d5.cohuck@redhat.com> (raw)
In-Reply-To: <1503318465-19013-3-git-send-email-borntraeger@de.ibm.com>
On Mon, 21 Aug 2017 14:27:45 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> sthyi should only generate a specification exception if the function
> code is zero and the response buffer is not on a 4k boundary.
>
> The current code would also test for unknown function codes if the
> response buffer, that is currently only defined for function code 0,
> is not on a 4k boundary and incorrectly inject a specification
> exception instead of returning with condition code 3 and return code 4
> (unsupported function code).
>
> Fix this by moving the boundary check.
>
> Fixes: 95ca2cb57985 ("KVM: s390: Add sthyi emulation")
> Cc: <stable@vger.kernel.org> # 4.8+
> Reviewed-by: Janosch Frank <frankja@linux.vnet.ibm.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> arch/s390/kvm/sthyi.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
prev parent reply other threads:[~2017-08-21 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 12:27 [PATCH 0/2] KVM: s390: two fixes for sthyi emulation (4.13) Christian Borntraeger
2017-08-21 12:27 ` [PATCH 1/2] KVM: s390: sthyi: fix sthyi inline assembly Christian Borntraeger
2017-08-21 12:44 ` David Hildenbrand
2017-08-21 13:07 ` Cornelia Huck
2017-08-21 12:27 ` [PATCH 2/2] KVM: s390: sthyi: fix specification exception detection Christian Borntraeger
2017-08-21 12:43 ` David Hildenbrand
2017-08-21 12:48 ` Christian Borntraeger
2017-08-21 13:09 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821150918.4df5d2d5.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox