From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH] vfio: platform: constify amba_id Date: Wed, 30 Aug 2017 15:24:36 -0600 Message-ID: <20170830152436.7a06373a@w520.home> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: b.reynal@virtualopensystems.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Arvind Yadav Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, 23 Aug 2017 22:47:15 +0530 Arvind Yadav wrote: > amba_id are not supposed to change at runtime. All functions > working with const amba_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/vfio/platform/vfio_amba.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/platform/vfio_amba.c b/drivers/vfio/platform/vfio_amba.c > index 31372fb..62dfbfe 100644 > --- a/drivers/vfio/platform/vfio_amba.c > +++ b/drivers/vfio/platform/vfio_amba.c > @@ -93,7 +93,7 @@ static int vfio_amba_remove(struct amba_device *adev) > return -EINVAL; > } > > -static struct amba_id pl330_ids[] = { > +static const struct amba_id pl330_ids[] = { > { 0, 0 }, > }; > Applied to next branch for v4.14. Thanks, Alex