From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH v1 1/4] KVM: s390: guestdbg: fix range check Date: Thu, 31 Aug 2017 12:13:32 +0200 Message-ID: <20170831121332.49ccceab.cohuck@redhat.com> References: <20170830160603.5452-1-david@redhat.com> <20170830160603.5452-2-david@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Christian Borntraeger , Paolo Bonzini , Radim =?UTF-8?B?S3LEjW3DocWZ?= To: David Hildenbrand Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44114 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbdHaKNh (ORCPT ); Thu, 31 Aug 2017 06:13:37 -0400 In-Reply-To: <20170830160603.5452-2-david@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 30 Aug 2017 18:06:00 +0200 David Hildenbrand wrote: > Looks like the "overflowing" range check is wrong. > > |=======b-------a=======| > > addr >= a || addr <= b Huh :) > > Signed-off-by: David Hildenbrand > --- > arch/s390/kvm/guestdbg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/kvm/guestdbg.c b/arch/s390/kvm/guestdbg.c > index c2e0ddc1356e..bcbd86621d01 100644 > --- a/arch/s390/kvm/guestdbg.c > +++ b/arch/s390/kvm/guestdbg.c > @@ -308,7 +308,7 @@ static inline int in_addr_range(u64 addr, u64 a, u64 b) > return (addr >= a) && (addr <= b); > else > /* "overflowing" interval */ > - return (addr <= a) && (addr >= b); > + return (addr >= a) || (addr <= b); > } > > #define end_of_range(bp_info) (bp_info->addr + bp_info->len - 1) Reviewed-by: Cornelia Huck