Re: [PATCH v1 3/4] KVM: s390: vsie: cleanup mcck reinjection

[Cornelia Huck <cohuck@redhat.com>]

On Thu, 31 Aug 2017 13:01:39 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> 
> I will add some patch description like:
> 
> We already know that the machine check information was part of the vsie_page.

Shorten that to "The machine check information is part of the
vsie_page."?

In any case,

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

> 
> applied.
> 
> On 08/30/2017 06:06 PM, David Hildenbrand wrote:
> > Signed-off-by: David Hildenbrand <david@redhat.com>
> > ---
> >  arch/s390/kvm/vsie.c | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> > 
> > diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
> > index 715c19c45d9a..b5eec30eb37d 100644
> > --- a/arch/s390/kvm/vsie.c
> > +++ b/arch/s390/kvm/vsie.c
> > @@ -806,8 +806,6 @@ static int do_vsie_run(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
> >  {
> >  	struct kvm_s390_sie_block *scb_s = &vsie_page->scb_s;
> >  	struct kvm_s390_sie_block *scb_o = vsie_page->scb_o;
> > -	struct mcck_volatile_info *mcck_info;
> > -	struct sie_page *sie_page;
> >  	int rc;
> > 
> >  	handle_last_fault(vcpu, vsie_page);
> > @@ -831,9 +829,7 @@ static int do_vsie_run(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
> > 
> >  	if (rc == -EINTR) {
> >  		VCPU_EVENT(vcpu, 3, "%s", "machine check");
> > -		sie_page = container_of(scb_s, struct sie_page, sie_block);
> > -		mcck_info = &sie_page->mcck_info;
> > -		kvm_s390_reinject_machine_check(vcpu, mcck_info);
> > +		kvm_s390_reinject_machine_check(vcpu, &vsie_page->mcck_info);
> >  		return 0;
> >  	}
> >   
>