From mboxrd@z Thu Jan  1 00:00:00 1970
From: Borislav Petkov <bp@suse.de>
Subject: Re: [RFC Part2 PATCH v3 05/26] KVM: SVM: Reserve ASID range for SEV
 guest
Date: Tue, 12 Sep 2017 22:28:11 +0200
Message-ID: <20170912202811.ykty35bx2tvahe5s@pd.tnic>
References: <20170724200303.12197-1-brijesh.singh@amd.com>
 <20170724200303.12197-6-brijesh.singh@amd.com>
 <20170912200416.ygcsqvznkkp2gd7r@pd.tnic>
 <bdc793a7-7e24-ec95-c56e-2223b6048afd@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Joerg Roedel <joro@8bytes.org>,
        "Michael S . Tsirkin" <mst@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?utf-8?B?XCJSYWRpbSBLcsSNbcOhxZlcIg==?= <rkrcmar@redhat.com>,
        Tom Lendacky <thomas.lendacky@amd.com>
To: Brijesh Singh <brijesh.singh@amd.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <bdc793a7-7e24-ec95-c56e-2223b6048afd@amd.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Tue, Sep 12, 2017 at 03:24:05PM -0500, Brijesh Singh wrote:
> > If anything, this comment should explain what that variable is.
> > Basically the comment you have in sev_hardware_setup() now.
> > 
> 
> Will add more comments.

I didn't mean that - I meant that /* Secure Encrypted Virtualization */
as a comment doesn't fit over the variable max_sev_asid. If anything, it should
explain the variable or not be there at all.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--