From: Marcelo Tosatti <mtosatti@redhat.com>
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Subject: [patch 3/3] x86: kvm guest side support for KVM_HC_RT_PRIO hypercall
Date: Thu, 21 Sep 2017 08:38:38 -0300 [thread overview]
Message-ID: <20170921114039.466130276@redhat.com> (raw)
In-Reply-To: 20170921113835.031375194@redhat.com
[-- Attachment #1: 03-kvm-hv-fifo-guest-support --]
[-- Type: text/plain, Size: 3173 bytes --]
Add hypercalls to spinlock/unlock to set/unset FIFO priority
for the vcpu, protected by a static branch to avoid performance
increase in the normal kernels.
Enable option by "kvmfifohc" kernel command line parameter (disabled
by default).
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
arch/x86/kernel/kvm.c | 31 +++++++++++++++++++++++++++++++
include/linux/spinlock.h | 2 +-
include/linux/spinlock_api_smp.h | 17 +++++++++++++++++
3 files changed, 49 insertions(+), 1 deletion(-)
Index: kvm.fifopriohc-submit/arch/x86/kernel/kvm.c
===================================================================
--- kvm.fifopriohc-submit.orig/arch/x86/kernel/kvm.c
+++ kvm.fifopriohc-submit/arch/x86/kernel/kvm.c
@@ -37,6 +37,7 @@
#include <linux/debugfs.h>
#include <linux/nmi.h>
#include <linux/swait.h>
+#include <linux/static_key.h>
#include <asm/timer.h>
#include <asm/cpu.h>
#include <asm/traps.h>
@@ -321,6 +322,36 @@ static notrace void kvm_guest_apic_eoi_w
apic->native_eoi_write(APIC_EOI, APIC_EOI_ACK);
}
+static int kvmfifohc;
+
+static int parse_kvmfifohc(char *arg)
+{
+ kvmfifohc = 1;
+ return 0;
+}
+
+early_param("kvmfifohc", parse_kvmfifohc);
+
+DEFINE_STATIC_KEY_FALSE(kvm_fifo_hc_key);
+
+static void kvm_init_fifo_hc(void)
+{
+ long ret;
+
+ ret = kvm_hypercall1(KVM_HC_RT_PRIO, 0);
+
+ if (ret == 0 && kvmfifohc == 1)
+ static_branch_enable(&kvm_fifo_hc_key);
+}
+
+static __init int kvmguest_late_init(void)
+{
+ kvm_init_fifo_hc();
+ return 0;
+}
+
+late_initcall(kvmguest_late_init);
+
static void kvm_guest_cpu_init(void)
{
if (!kvm_para_available())
Index: kvm.fifopriohc-submit/include/linux/spinlock_api_smp.h
===================================================================
--- kvm.fifopriohc-submit.orig/include/linux/spinlock_api_smp.h
+++ kvm.fifopriohc-submit/include/linux/spinlock_api_smp.h
@@ -136,11 +136,28 @@ static inline void __raw_spin_lock_bh(ra
LOCK_CONTENDED(lock, do_raw_spin_trylock, do_raw_spin_lock);
}
+#ifdef CONFIG_KVM_GUEST
+DECLARE_STATIC_KEY_FALSE(kvm_fifo_hc_key);
+#endif
+
static inline void __raw_spin_lock(raw_spinlock_t *lock)
{
preempt_disable();
+
+#if defined(CONFIG_KVM_GUEST) && defined(CONFIG_SMP)
+ /* enable FIFO priority */
+ if (static_branch_unlikely(&kvm_fifo_hc_key))
+ kvm_hypercall1(KVM_HC_RT_PRIO, 0x1);
+#endif
+
spin_acquire(&lock->dep_map, 0, 0, _RET_IP_);
LOCK_CONTENDED(lock, do_raw_spin_trylock, do_raw_spin_lock);
+
+#if defined(CONFIG_KVM_GUEST) && defined(CONFIG_SMP)
+ /* disable FIFO priority */
+ if (static_branch_unlikely(&kvm_fifo_hc_key))
+ kvm_hypercall1(KVM_HC_RT_PRIO, 0);
+#endif
}
#endif /* !CONFIG_GENERIC_LOCKBREAK || CONFIG_DEBUG_LOCK_ALLOC */
Index: kvm.fifopriohc-submit/include/linux/spinlock.h
===================================================================
--- kvm.fifopriohc-submit.orig/include/linux/spinlock.h
+++ kvm.fifopriohc-submit/include/linux/spinlock.h
@@ -56,7 +56,7 @@
#include <linux/stringify.h>
#include <linux/bottom_half.h>
#include <asm/barrier.h>
-
+#include <uapi/linux/kvm_para.h>
/*
* Must define these before including other files, inline functions need them
next prev parent reply other threads:[~2017-09-21 11:38 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 11:38 [patch 0/3] KVM KVM_HC_RT_PRIO hypercall support Marcelo Tosatti
2017-09-21 11:38 ` [patch 1/3] KVM: x86: add per-vcpu option to set guest vcpu -RT priority Marcelo Tosatti
2017-09-21 11:38 ` [patch 2/3] KVM: x86: KVM_HC_RT_PRIO hypercall (host-side) Marcelo Tosatti
2017-09-21 13:32 ` Konrad Rzeszutek Wilk
2017-09-21 13:49 ` Paolo Bonzini
2017-09-22 1:08 ` Marcelo Tosatti
2017-09-22 7:23 ` Paolo Bonzini
2017-09-22 12:24 ` Marcelo Tosatti
2017-09-21 11:38 ` Marcelo Tosatti [this message]
2017-09-21 13:36 ` [patch 3/3] x86: kvm guest side support for KVM_HC_RT_PRIO hypercall Konrad Rzeszutek Wilk
2017-09-21 14:06 ` Peter Zijlstra
2017-09-22 1:10 ` Marcelo Tosatti
2017-09-22 10:00 ` Peter Zijlstra
2017-09-22 10:56 ` Peter Zijlstra
2017-09-22 12:33 ` Marcelo Tosatti
2017-09-22 12:55 ` Peter Zijlstra
2017-09-23 10:56 ` Paolo Bonzini
2017-09-23 13:41 ` Peter Zijlstra
2017-09-24 13:05 ` Paolo Bonzini
2017-09-25 2:57 ` Marcelo Tosatti
2017-09-25 9:13 ` Peter Zijlstra
2017-09-25 15:12 ` Paolo Bonzini
2017-09-26 22:49 ` [patch 3/3] x86: kvm guest side support for KVM_HC_RT_PRIO hypercall\ Marcelo Tosatti
2017-09-27 9:37 ` Paolo Bonzini
2017-09-28 0:44 ` Marcelo Tosatti
2017-09-28 7:22 ` Paolo Bonzini
2017-09-28 21:35 ` Marcelo Tosatti
2017-09-28 21:41 ` Marcelo Tosatti
2017-09-29 8:18 ` Paolo Bonzini
2017-09-29 16:40 ` Marcelo Tosatti
2017-09-29 17:05 ` Paolo Bonzini
2017-09-29 20:17 ` Marcelo Tosatti
2017-10-02 12:30 ` Paolo Bonzini
2017-10-02 12:48 ` Peter Zijlstra
2017-09-26 23:22 ` [patch 3/3] x86: kvm guest side support for KVM_HC_RT_PRIO hypercall Marcelo Tosatti
2017-09-25 16:20 ` Konrad Rzeszutek Wilk
2017-09-22 12:16 ` Marcelo Tosatti
2017-09-22 12:31 ` Peter Zijlstra
2017-09-22 12:36 ` Marcelo Tosatti
2017-09-22 12:59 ` Peter Zijlstra
2017-09-25 1:52 ` Marcelo Tosatti
2017-09-25 8:35 ` Peter Zijlstra
2017-09-22 12:40 ` [patch 3/3] x86: kvm guest side support for KVM_HC_RT_PRIO hypercall\ Marcelo Tosatti
2017-09-22 13:01 ` Peter Zijlstra
2017-09-25 2:22 ` Marcelo Tosatti
2017-09-25 8:58 ` Peter Zijlstra
2017-09-25 10:41 ` Thomas Gleixner
2017-09-25 18:28 ` Jan Kiszka
2017-09-21 17:45 ` [patch 0/3] KVM KVM_HC_RT_PRIO hypercall support Jan Kiszka
2017-09-22 1:19 ` Marcelo Tosatti
2017-09-22 6:23 ` Jan Kiszka
2017-09-26 23:59 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921114039.466130276@redhat.com \
--to=mtosatti@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox