From: Christoph Hellwig <hch@infradead.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
axboe@kernel.de, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: drop "sending ioctl to a partition" message
Date: Thu, 21 Sep 2017 07:53:00 -0700 [thread overview]
Message-ID: <20170921145300.GA1617@infradead.org> (raw)
In-Reply-To: <1506005362-13429-1-git-send-email-pbonzini@redhat.com>
This looks ok to me, but do we even need to keep the special
cases above? Is there anything relying on the safe but not very
useful ioctls?
Condensing the thing down to:
int scsi_verify_blk_ioctl(struct block_device *bd, unsigned int cmd)
{
if (bd && bd == bd->bd_contains)
return 0;
if (capable(CAP_SYS_RAWIO))
return 0;
return -ENOIOCTLCMD;
}
would certainly be nice.
next prev parent reply other threads:[~2017-09-21 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 14:49 [PATCH] block: drop "sending ioctl to a partition" message Paolo Bonzini
2017-09-21 14:53 ` Christoph Hellwig [this message]
2017-09-21 14:59 ` Paolo Bonzini
2017-10-03 16:22 ` Paolo Bonzini
2017-10-04 6:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921145300.GA1617@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.de \
--cc=kvm@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox