public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Thomas Huth <thuth@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Halil Pasic <pasic@linux.vnet.ibm.com>,
	linux-s390@vger.kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: s390: Disable CONFIG_S390_GUEST_OLD_TRANSPORT by default
Date: Tue, 26 Sep 2017 13:10:52 +0200	[thread overview]
Message-ID: <20170926131052.4f97f86d.cohuck@redhat.com> (raw)
In-Reply-To: <20170926110403.GC3209@osiris>

On Tue, 26 Sep 2017 13:04:03 +0200
Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> On Tue, Sep 26, 2017 at 12:57:26PM +0200, Thomas Huth wrote:
> > On 26.09.2017 12:47, Heiko Carstens wrote:  
> > > So it's going to be removed with the next merge window.
> > > Where is the patch? ;)  
> > 
> > Hmm, so far the code was always enabled by default, so in the unlikely
> > case that somebody is still using it, they might not have noticed that
> > this is marked as deprecated. So maybe it's better to keep the code for
> > two more released, but disable it by default, so that people have time
> > to realize that it is going away? ... just my 0.02 € ... but if you
> > prefer, I can also write a patch that removes it immediately instead.  
> 
> Switching the default from yes to no won't prevent anybody from selecting
> it again. So I don't see any value in waiting even longer.
> 
> Besides the original commit already printed a message to the console that
> the transport is deprecated.
> See commit 3b2fbb3f06ef ("virtio/s390: deprecate old transport").
> 

Would ack a removal as well.

  reply	other threads:[~2017-09-26 11:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25 14:45 [PATCH] KVM: s390: Disable CONFIG_S390_GUEST_OLD_TRANSPORT by default Thomas Huth
2017-09-25 17:54 ` Halil Pasic
2017-09-25 18:37   ` Christian Borntraeger
2017-09-26  2:44     ` Thomas Huth
2017-09-26 10:40     ` Heiko Carstens
2017-09-26 10:41       ` Christian Borntraeger
2017-09-26 10:47         ` Heiko Carstens
2017-09-26 10:57           ` Thomas Huth
2017-09-26 11:04             ` Heiko Carstens
2017-09-26 11:10               ` Cornelia Huck [this message]
2017-09-26  7:33 ` Christian Borntraeger
2017-09-26  7:53 ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170926131052.4f97f86d.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pasic@linux.vnet.ibm.com \
    --cc=thuth@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox