From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Carstens Subject: Re: [PATCH] drivers/s390/virtio: Remove the old KVM virtio transport Date: Wed, 27 Sep 2017 14:55:30 +0200 Message-ID: <20170927125530.GE4032@osiris> References: <1506512521-2244-1-git-send-email-thuth@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Halil Pasic , Cornelia Huck , linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Christian Borntraeger , Martin Schwidefsky To: Thomas Huth Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:51818 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752603AbdI0Mzh (ORCPT ); Wed, 27 Sep 2017 08:55:37 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v8RCoRYb140254 for ; Wed, 27 Sep 2017 08:55:37 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 2d89n7sjx6-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 27 Sep 2017 08:55:36 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Sep 2017 13:55:35 +0100 Content-Disposition: inline In-Reply-To: <1506512521-2244-1-git-send-email-thuth@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Sep 27, 2017 at 01:42:01PM +0200, Thomas Huth wrote: > diff --git a/drivers/s390/virtio/Makefile b/drivers/s390/virtio/Makefile > index df40692..d9942e0 100644 > --- a/drivers/s390/virtio/Makefile > +++ b/drivers/s390/virtio/Makefile > @@ -7,7 +7,4 @@ > # as published by the Free Software Foundation. > > s390-virtio-objs := virtio_ccw.o > -ifdef CONFIG_S390_GUEST_OLD_TRANSPORT > -s390-virtio-objs += kvm_virtio.o > -endif > obj-$(CONFIG_S390_GUEST) += $(s390-virtio-objs) Would you mind to simplify the Makefile to just the single line obj-$(CONFIG_S390_GUEST) += virtio_ccw.o while you are touching it anyway?