From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Carstens Subject: Re: [PATCH] drivers/s390/virtio: Remove the old KVM virtio transport Date: Wed, 27 Sep 2017 16:10:23 +0200 Message-ID: <20170927141023.GF4032@osiris> References: <1506512521-2244-1-git-send-email-thuth@redhat.com> <20170927125530.GE4032@osiris> <66822fa4-f7fe-565a-bc51-9fe1493378f9@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Halil Pasic , Cornelia Huck , linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Christian Borntraeger , Martin Schwidefsky To: Thomas Huth Return-path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:49120 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752030AbdI0OKb (ORCPT ); Wed, 27 Sep 2017 10:10:31 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v8RE7Xo4061227 for ; Wed, 27 Sep 2017 10:10:30 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2d89s5wnma-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 27 Sep 2017 10:10:30 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Sep 2017 15:10:28 +0100 Content-Disposition: inline In-Reply-To: <66822fa4-f7fe-565a-bc51-9fe1493378f9@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Sep 27, 2017 at 03:06:55PM +0200, Thomas Huth wrote: > On 27.09.2017 14:55, Heiko Carstens wrote: > > On Wed, Sep 27, 2017 at 01:42:01PM +0200, Thomas Huth wrote: > >> diff --git a/drivers/s390/virtio/Makefile b/drivers/s390/virtio/Makefile > >> index df40692..d9942e0 100644 > >> --- a/drivers/s390/virtio/Makefile > >> +++ b/drivers/s390/virtio/Makefile > >> @@ -7,7 +7,4 @@ > >> # as published by the Free Software Foundation. > >> > >> s390-virtio-objs := virtio_ccw.o > >> -ifdef CONFIG_S390_GUEST_OLD_TRANSPORT > >> -s390-virtio-objs += kvm_virtio.o > >> -endif > >> obj-$(CONFIG_S390_GUEST) += $(s390-virtio-objs) > > > > Would you mind to simplify the Makefile to just the single line > > > > obj-$(CONFIG_S390_GUEST) += virtio_ccw.o > > > > while you are touching it anyway? > > Sure ... I'll send a v2 ... or do you rather want to fix it when picking > up the patch? I will change it accordingly.