From: Alex Williamson <alex.williamson@redhat.com>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, kwankhede@nvidia.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio-mdev: make mdev_fops const and static
Date: Mon, 2 Oct 2017 13:10:35 -0600 [thread overview]
Message-ID: <20171002131035.4f901999@t450s.home> (raw)
In-Reply-To: <1506788244-6864-1-git-send-email-bhumirks@gmail.com>
On Sat, 30 Sep 2017 21:47:24 +0530
Bhumika Goyal <bhumirks@gmail.com> wrote:
> Make this const as it is only passed to a const argument of the function
> mdev_register_device. Make it static as it is not referenced in any
> other file.
>
> Structure found using Coccinelle and changes done by hand.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> samples/vfio-mdev/mtty.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
> index ca49568..09f255b 100644
> --- a/samples/vfio-mdev/mtty.c
> +++ b/samples/vfio-mdev/mtty.c
> @@ -1413,7 +1413,7 @@ struct attribute_group *mdev_type_groups[] = {
> NULL,
> };
>
> -struct mdev_parent_ops mdev_fops = {
> +static const struct mdev_parent_ops mdev_fops = {
> .owner = THIS_MODULE,
> .dev_attr_groups = mtty_dev_groups,
> .mdev_attr_groups = mdev_dev_groups,
Applied to vfio next branch for v4.15. Thanks,
Alex
prev parent reply other threads:[~2017-10-02 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 16:17 [PATCH] vfio-mdev: make mdev_fops const and static Bhumika Goyal
2017-10-02 19:10 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002131035.4f901999@t450s.home \
--to=alex.williamson@redhat.com \
--cc=bhumirks@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox