From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Desaulniers Subject: Re: [PATCH] KVM: VMX: check match table Date: Tue, 3 Oct 2017 19:54:17 -0700 Message-ID: <20171004025417.a3avsq4ockpgtivd@lostoracle.net> References: <20170926042540.10100-1-nick.desaulniers@gmail.com> <20170926171219.ulnknakiohm2whpd@x> <498ed7dc-41b2-a075-cdce-e63a80842d39@redhat.com> <20170930232234.ue665ojgjkegjpag@lostoracle.net> <28a852ce-9fa4-0b41-6867-1659849a8037@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Josh Triplett , kay@vrfy.org, avi@redhat.com, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Paolo Bonzini Return-path: Content-Disposition: inline In-Reply-To: <28a852ce-9fa4-0b41-6867-1659849a8037@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, Oct 03, 2017 at 11:42:18AM +0200, Paolo Bonzini wrote: > On 01/10/2017 01:22, Nick Desaulniers wrote: > > I don't follow (but I also don't know what any of these three letter > > acryonyms acronyms stand for), does svm depend on vmx or vice-versa? > Neither, one is Intel (VMX), the other is AMD (SVM). Oh, neat, did not realize the vendors did not have different names for their virtualization extensions. https://rtfmp.com/2016/03/21/what-does-vmx-svm-cpu-flags-mean/ > Would this work for you? It doesn't apply cleanly on Linus' tree, or the KVM tree master branch, so I couldn't fully test it. But it does look like it will do the trick. > And again, is this only with clang? Indeed the warning was coming from Clang, but looks like some additional cleanup was done, which is good. Reviewed-by: Nick Desaulniers