From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH] KVM: add X86_LOCAL_APIC dependency
Date: Thu, 5 Oct 2017 20:01:10 +0200
Message-ID: <20171005180107.GJ21107@flask>
References: <20171004102823.1887173-1-arnd@arndb.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Juergen Gross <jgross@suse.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
To: Arnd Bergmann <arnd@arndb.de>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20171004102823.1887173-1-arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

2017-10-04 12:28+0200, Arnd Bergmann:
> The rework of the posted interrupt handling broke building without
> support for the local APIC:
> 
> ERROR: "boot_cpu_physical_apicid" [arch/x86/kvm/kvm-intel.ko] undefined!
> 
> That configuration is probably not particularly useful anyway, so
> we can avoid the randconfig failures by adding a Kconfig dependency.

Yeah, and we can follow up by removing few ifdefs.

> Fixes: 8b306e2f3c41 ("KVM: VMX: avoid double list add with VT-d posted interrupts")

The offending cpu_physical_id() was there even before, so it is probably
the change of condition in pi_post_block that violated dead code
detection.

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Applied, thanks.