From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH v5 3/3] KVM: LAPIC: Apply change to TDCR right away to
 the timer
Date: Fri, 6 Oct 2017 16:20:03 +0200
Message-ID: <20171006142003.GB16459@flask>
References: <1507214117-2899-1-git-send-email-wanpeng.li@hotmail.com>
 <20171005181427.GB5656@flask>
 <CANRm+CzQtB99=+OG1ZbQkd1s=kUMQO=PM5QRqK6f_7Y6U+_7Fw@mail.gmail.com>
 <20171006130318.GA16459@flask>
 <CANRm+CzRw2zMxPMTC1AFgDML1RbtgUV=ucy10gSzwdqJV6o7mQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>
To: Wanpeng Li <kernellwp@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <CANRm+CzRw2zMxPMTC1AFgDML1RbtgUV=ucy10gSzwdqJV6o7mQ@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

2017-10-06 22:03+0800, Wanpeng Li:
> 2017-10-06 21:03 GMT+08:00 Radim Krčmář <rkrcmar@redhat.com>:
> > 2017-10-06 07:14+0800, Wanpeng Li:
> >> 2017-10-06 2:14 GMT+08:00 Radim Krčmář <rkrcmar@redhat.com>:
> >> > 2017-10-05 07:35-0700, Wanpeng Li:
> >> >> From: Wanpeng Li <wanpeng.li@hotmail.com>
> >> >> +             remaining = ktime_sub(apic->lapic_timer.target_expiration, now);
> >> >> +             if (ktime_to_ns(remaining) < 0)
> >> >> +                     remaining = 0;
> >> >> +             delta = mod_64(ktime_to_ns(remaining), apic->lapic_timer.period);
> >> >> +
> >> >> +             if (!delta)
> >> >> +                     return false;
> >> >> +
> >> >> +             apic->lapic_timer.period = (u64)kvm_lapic_get_reg(apic, APIC_TMICT)
> >> >> +                     * APIC_BUS_CYCLE_NS * apic->divide_count;
> >> >
> >> > I'd prefer to apply the rate limiting (done earlier in this function) to
> >> > the period.  This version allows the guest to configure 128 times more
> >> > frequent interrupts in the host.
> >> > (And thinking about it, the version of [2/3] I proposed has similar
> >> >  problem when switching from one-shot to periodic, only there it is
> >> >  unpredictably limited by the speed of KVM.)
> >>
> >> We didn't stop and restart the timer, why the rate will influence us for [2/3]?
> >
> > It is because of the rate limiting -- the guest could setup a one-shot
> > timer with a short expiration and switch to periodic
> 
> Yeah, in addition, I think configure 128 means more slower interrupts
> instead of faster.

Yes, it says how many cycles it takes to decrement APIC_TMCCT.

(I only concerned about the case where rate limit was configured with
 divide_count=128 and then switched to 1.)