From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH v8] KVM: LAPIC: Apply change to TDCR right away to the timer Date: Fri, 6 Oct 2017 17:02:00 +0200 Message-ID: <20171006150200.GE16466@flask> References: <1507300712-9317-1-git-send-email-wanpeng.li@hotmail.com> <12d7651f-868e-aaec-6e91-a53f9819d817@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Wanpeng Li , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Wanpeng Li To: Paolo Bonzini Return-path: Content-Disposition: inline In-Reply-To: <12d7651f-868e-aaec-6e91-a53f9819d817@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org 2017-10-06 16:51+0200, Paolo Bonzini: > On 06/10/2017 16:38, Wanpeng Li wrote: > > + now = ktime_get(); > > + remaining = ktime_sub(apic->lapic_timer.target_expiration, now); > > Still need to compare against zero here. I guess Radim can do it. I added the expression from v7 while applying, thanks. if (ktime_to_ns(remaining) < 0) remaining = 0; > > + ns_remaining_old = ktime_to_ns(remaining); > > + ns_remaining_new = mul_u64_u32_div(ns_remaining_old, > > + apic->divide_count, old_divisor); > > + > > + apic->lapic_timer.tscdeadline += nsec_to_cycles(apic->vcpu, ns_remaining_new) - > > + nsec_to_cycles(apic->vcpu, ns_remaining_old); > > + apic->lapic_timer.target_expiration = ktime_add_ns(now, ns_remaining_new);