From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH v2 00/15] KVM x86/VMX cleanups Date: Fri, 6 Oct 2017 20:11:57 +0200 Message-ID: <20171006181156.GB21645@flask> References: <20170824185137.6253-1-david@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Paolo Bonzini To: David Hildenbrand Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13815 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752768AbdJFSMC (ORCPT ); Fri, 6 Oct 2017 14:12:02 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 872271E2E8 for ; Fri, 6 Oct 2017 18:12:02 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170824185137.6253-1-david@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2017-08-24 20:51+0200, David Hildenbrand: > Some cleanups discovered while digging through the code. > > v1 -> v2: > - dropped "KVM: x86: mmu: use for_each_shadow_entry_lockless()" > - added "KVM: VMX: rename RDSEED and RDRAND vmx ctrls to reflect exiting" > - added "KVM: nVMX: no need to set ept/vpid caps to 0" > - added "KVM: VMX: drop enable_ept check from ept_sync_context()" Resolved few minor conflicts and queued, thanks. > David Hildenbrand (15): > KVM: x86: mmu: returning void in a void function is strange > KVM: x86: mmu: free_page can handle NULL > KVM: x86: drop BUG_ON(vcpu->kvm) > KVM: VMX: vmx_vcpu_setup() cannot fail > KVM: x86: no need to inititalize vcpu members to 0 > KVM: VMX: drop enable_ept check from ept_sync_context() > KVM: VMX: call ept_sync_global() with enable_ept only > KVM: VMX: require INVEPT GLOBAL for EPT > KVM: VMX: drop unnecessary function declarations > KVM: nVMX: no need to set vcpu->cpu when switching vmcs > KVM: nVMX: no need to set ept/vpid caps to 0 > KVM: VMX: cleanup init_rmode_identity_map() > KVM: x86: document special identity map address value > KVM: x86: allow setting identity map addr with no vcpus only > KVM: VMX: rename RDSEED and RDRAND vmx ctrls to reflect exiting > > Documentation/virtual/kvm/api.txt | 4 ++ > arch/x86/include/asm/vmx.h | 4 +- > arch/x86/kvm/mmu.c | 5 +- > arch/x86/kvm/vmx.c | 96 ++++++++++++++------------------------- > arch/x86/kvm/x86.c | 21 ++++----- > 5 files changed, 51 insertions(+), 79 deletions(-) > > -- > 2.13.5 >