From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Hansen Subject: [PATCH] arch/x86: remove redundant null checks before kmem_cache_destroy Date: Sat, 7 Oct 2017 23:15:23 -0400 Message-ID: <20171008031523.jj63si46bgb27yxu@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: rkrcmar@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, alexander.levin@one.verizon.com, devtimhansen@gmail.com To: pbonzini@redhat.com Return-path: Received: from mail-qt0-f196.google.com ([209.85.216.196]:52444 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753187AbdJHDPa (ORCPT ); Sat, 7 Oct 2017 23:15:30 -0400 Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: Remove redundant null checks before calling kmem_cache_destroy. Found with make coccicheck M=arch/x86/kvm on linux-next tag next-20170929. Signed-off-by: Tim Hansen --- arch/x86/kvm/mmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index eca30c1eb1d9..a6c7177326c5 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -5463,10 +5463,8 @@ static struct shrinker mmu_shrinker = { static void mmu_destroy_caches(void) { - if (pte_list_desc_cache) - kmem_cache_destroy(pte_list_desc_cache); - if (mmu_page_header_cache) - kmem_cache_destroy(mmu_page_header_cache); + kmem_cache_destroy(pte_list_desc_cache); + kmem_cache_destroy(mmu_page_header_cache); } int kvm_mmu_module_init(void) -- 2.14.2