From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tobin C. Harding" Subject: Re: [PATCH] KVM: remove printing of token address Date: Mon, 9 Oct 2017 21:04:15 +1100 Message-ID: <20171009100415.GA12785@eros> References: <1507530614-10504-1-git-send-email-me@tobin.cc> <1845029054.11118038.1507535378802.JavaMail.zimbra@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: rkrcmar@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Paolo Bonzini Return-path: Content-Disposition: inline In-Reply-To: <1845029054.11118038.1507535378802.JavaMail.zimbra@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, Oct 09, 2017 at 03:49:38AM -0400, Paolo Bonzini wrote: > > > ----- Original Message ----- > > From: "Tobin C. Harding" > > To: "Paolo Bonzini" , rkrcmar@redhat.com > > Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, "Tobin C. Harding" > > Sent: Monday, October 9, 2017 8:30:14 AM > > Subject: [PATCH] KVM: remove printing of token address > > > > KVM currently prints the address of the consumer token. It is not > > immediately clear what benefit it is to see this address. Printing > > this address leaks kernel pointers into dmesg and is a security risk. > > > > Remove the consumer token address from error message output. > > It should use %pK instead. Is there any other way we can identify a token? There is some push back against kpt_restrict (as used by %pK) at the moment. If there is another sane way to do it perhaps we could consider that, else I'll use %pK for v2. > Also, please do the same change on the VFIO > side (drivers/vfio/pci/vfio_pci_intrs.c, call to irq_bypass_register_producer). Oh, cool. I was wondering where the other side was. Will send v2 thanks, Tobin.