From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tobin C. Harding" Subject: Re: [PATCH 0/3] add %pX specifier Date: Wed, 11 Oct 2017 10:31:16 +1100 Message-ID: <20171010233116.GA2049@eros> References: <1507676974-1298-1-git-send-email-me@tobin.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "kernel-hardening@lists.openwall.com" , KVM list , Linux Kernel Mailing List , Kees Cook , Paolo Bonzini , Tycho Andersen , "Roberts, William C" , Tejun Heo , Jordan Glover , Greg KH , Petr Mladek , Joe Perches , Ian Campbell , Sergey Senozhatsky , Catalin Marinas , Will Deacon , Steven Rostedt , Chris Fries , Dave Weinstein To: Linus Torvalds Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, Oct 10, 2017 at 04:16:55PM -0700, Linus Torvalds wrote: > On Tue, Oct 10, 2017 at 4:09 PM, Tobin C. Harding wrote: > > > > This patch is a softer version of Linus' suggestion because it does not change the behaviour of the > > %p specifier. I don't see the benefit in making such a breaking change without addressing the issue > > of %x (and I don't the balls to right now). > > The thing is, this continues to have the exact same issue that %pK has > - because it is opt-in, effectively nobody will actually use it. > > That's why I would suggest that if we do this way, we really change %p > and %pa to use the hashed value, to convert *everybody*. And then > people who have a good reason to actually expose the pointer have to > do the extra work and opt out. > > Linus Righto, I'll wait 24 hours and submit v2 with the change as suggested. I guess now is as good a time as any annoy everybody and cause them to do work (for the greater good :) Then I can direct effort at finding any users of %x for kernel addresses. thanks, Tobin.