From: "Tobin C. Harding" <me@tobin.cc>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
KVM list <kvm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Tycho Andersen <tycho@docker.com>,
"Roberts, William C" <william.c.roberts@intel.com>,
Tejun Heo <tj@kernel.org>,
Jordan Glover <Golden_Miller83@protonmail.ch>,
Greg KH <gregkh@linuxfoundation.org>,
Petr Mladek <pmladek@suse.com>, Joe Perches <joe@perches.com>,
Ian Campbell <ijc@hellion.org.uk>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Chris Fries <cfries@google.com>,
Dave Weinstein
Subject: Re: [PATCH 0/3] add %pX specifier
Date: Wed, 11 Oct 2017 10:32:09 +1100 [thread overview]
Message-ID: <20171010233209.GB2049@eros> (raw)
In-Reply-To: <CA+55aFx56_4ERvNfdvQUk4yFF5UXWPkwg5g=QwS820nxAK0Bcg@mail.gmail.com>
On Tue, Oct 10, 2017 at 04:15:01PM -0700, Linus Torvalds wrote:
> On Tue, Oct 10, 2017 at 4:09 PM, Tobin C. Harding <me@tobin.cc> wrote:
> >
> > I did not understand the code (specifically why the right shift of 16 twice?)
>
> It's a traditional trick to get the upper 32 bits.
>
> So it basically splits the (possibly 64-bit) pointer into the lower 32
> bits and the upper 32 bits for a hash such as "jhash()" that takes
> data that is "unsigned int".
>
> (NOTE! Using jhash here is not acceptable, since it's not
> cryptographically safe, but think of it as an example of a hash that
> takes 32-bit input).
>
> Doing ">> 32" is undefined on 32-bit architectures, and wouldn't work.
>
> But doing >> 16 >> 16 is a fine way to say "shift right by 32 on a
> 64-bit architecture" while also being well-defined on a 32-bit one.
>
> Linus
Awesome, thanks.
Tobin.
next prev parent reply other threads:[~2017-10-10 23:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 23:09 [PATCH 0/3] add %pX specifier Tobin C. Harding
2017-10-10 23:15 ` Linus Torvalds
2017-10-10 23:32 ` Tobin C. Harding [this message]
2017-10-11 3:27 ` Joe Perches
2017-10-11 20:11 ` Jason A. Donenfeld
2017-10-11 21:29 ` Linus Torvalds
2017-10-11 22:11 ` Jason A. Donenfeld
2017-10-12 18:37 ` Linus Torvalds
2017-10-10 23:16 ` Linus Torvalds
2017-10-10 23:31 ` Tobin C. Harding
2017-10-13 17:54 ` Roberts, William C
2017-10-16 2:09 ` Tobin Harding
2017-10-11 20:09 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010233209.GB2049@eros \
--to=me@tobin.cc \
--cc=Golden_Miller83@protonmail.ch \
--cc=catalin.marinas@arm.com \
--cc=cfries@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=ijc@hellion.org.uk \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tycho@docker.com \
--cc=will.deacon@arm.com \
--cc=william.c.roberts@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox