From: Cornelia Huck <cohuck@redhat.com>
To: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org, borntraeger@de.ibm.com,
pasic@linux.vnet.ibm.com, pmorel@linux.vnet.ibm.com
Subject: Re: [PATCH 2/2] vfio: ccw: validate the count field of a ccw before pinning
Date: Mon, 16 Oct 2017 11:14:20 +0200 [thread overview]
Message-ID: <20171016111420.4a8ca1af.cohuck@redhat.com> (raw)
In-Reply-To: <20171011023822.42948-3-bjsdjshi@linux.vnet.ibm.com>
On Wed, 11 Oct 2017 04:38:22 +0200
Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> wrote:
> If the count field of a ccw is zero, there is no need to
> try to pin page(s) for it. Let's check the count value
> before starting pinning operations.
>
> Reviewed-by: Pierre Morel <pmorel@linux.vnet.ibm.com>
> Signed-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_cp.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
This sounds reasonable, and I could not spot anything in the
architecture that speaks against simply setting the IDA flag. Hopefully
there's nothing buried out of sight :)
next prev parent reply other threads:[~2017-10-16 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 2:38 [PATCH 0/2] vfio-ccw bugfix Dong Jia Shi
2017-10-11 2:38 ` [PATCH 1/2] vfio: ccw: bypass bad idaw address when fetching IDAL ccws Dong Jia Shi
2017-10-16 9:09 ` Cornelia Huck
2017-10-11 2:38 ` [PATCH 2/2] vfio: ccw: validate the count field of a ccw before pinning Dong Jia Shi
2017-10-16 9:14 ` Cornelia Huck [this message]
2017-10-16 9:37 ` [PATCH 0/2] vfio-ccw bugfix Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016111420.4a8ca1af.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox