From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Haozhong Zhang <haozhong.zhang@intel.com>,
Olif Chapman <olif.chapman@oracle.com>
Cc: kvm@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
rkrcmar@redhat.com, Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
ivan.d.cuevas.escareno@intel.com, karthik.kumar@intel.com,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Borislav Petkov <bp@suse.de>,
Mikulas Patocka <mpatocka@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v2 0/2] KVM: MMU: fix kvm_is_mmio_pfn()
Date: Thu, 2 Nov 2017 13:37:48 -0400 [thread overview]
Message-ID: <20171102173748.GU22924@char.us.oracle.com> (raw)
In-Reply-To: <20171031114840.12615-1-haozhong.zhang@intel.com>
On Tue, Oct 31, 2017 at 07:48:38PM +0800, Haozhong Zhang wrote:
> [I just copy the commit message from patch 2]
>
> Some reserved pages, such as those from NVDIMM DAX devices, are
> not for MMIO, and can be mapped with cached memory type for better
> performance. However, the above check misconceives those pages as
> MMIO. Because KVM maps MMIO pages with UC memory type, the
> performance of guest accesses to those pages would be harmed.
> Therefore, we check the host memory type by lookup_memtype() in
> addition and only treat UC/UC- pages as MMIO.
Is there a specific workload you used to detect this?
Thanks!
>
> Changes in v2:
> * Switch to lookup_memtype() to get host memory type.
> * Rewrite the comment in KVM MMU patch.
> * Remove v1 patch 2, which is not necessary in v2.
>
> Haozhong Zhang (2):
> x86/mm: expose lookup_memtype()
> KVM: MMU: consider host cache mode in MMIO page check
>
> arch/x86/include/asm/pat.h | 2 ++
> arch/x86/kvm/mmu.c | 30 +++++++++++++++++++++++++++---
> arch/x86/mm/pat.c | 3 ++-
> 3 files changed, 31 insertions(+), 4 deletions(-)
>
> --
> 2.14.1
>
next prev parent reply other threads:[~2017-11-02 17:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 11:48 [PATCH v2 0/2] KVM: MMU: fix kvm_is_mmio_pfn() Haozhong Zhang
2017-10-31 11:48 ` [PATCH v2 1/2] x86/mm: expose lookup_memtype() Haozhong Zhang
2017-10-31 11:48 ` [PATCH v2 2/2] KVM: MMU: consider host cache mode in MMIO page check Haozhong Zhang
2017-11-02 7:56 ` Xiao Guangrong
2017-11-02 9:20 ` Haozhong Zhang
2017-11-02 6:48 ` [PATCH v2 0/2] KVM: MMU: fix kvm_is_mmio_pfn() Haozhong Zhang
2017-11-02 17:37 ` Konrad Rzeszutek Wilk [this message]
2017-11-03 0:26 ` Haozhong Zhang
2017-11-03 14:15 ` Mikulas Patocka
2017-11-08 1:30 ` Haozhong Zhang
2017-11-08 12:24 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102173748.GU22924@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=bp@suse.de \
--cc=dan.j.williams@intel.com \
--cc=haozhong.zhang@intel.com \
--cc=hpa@zytor.com \
--cc=ivan.d.cuevas.escareno@intel.com \
--cc=karthik.kumar@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mpatocka@redhat.com \
--cc=olif.chapman@oracle.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox