From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH 1/4] KVM: nVMX: Fix vmx_check_nested_events() return value in case an event was reinjected to L2 Date: Fri, 10 Nov 2017 22:44:27 +0100 Message-ID: <20171110214426.GK2189@flask> References: <1509890866-8736-1-git-send-email-liran.alon@oracle.com> <1509890866-8736-2-git-send-email-liran.alon@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: pbonzini@redhat.com, kvm@vger.kernel.org, jmattson@google.com, idan.brown@oracle.com, Konrad Rzeszutek Wilk To: Liran Alon Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46734 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbdKJVoc (ORCPT ); Fri, 10 Nov 2017 16:44:32 -0500 Content-Disposition: inline In-Reply-To: <1509890866-8736-2-git-send-email-liran.alon@oracle.com> Sender: kvm-owner@vger.kernel.org List-ID: 2017-11-05 16:07+0200, Liran Alon: > vmx_check_nested_events() should return -EBUSY only in case there is a > pending L1 event which requires a VMExit from L2 to L1 but such a > VMExit is currently blocked. Such VMExits are blocked either > because nested_run_pending=1 or an event was reinjected to L2. > vmx_check_nested_events() should return 0 in case there are no > pending L1 events which requires a VMExit from L2 to L1 or if > a VMExit from L2 to L1 was done internally. > > However, upstream commit which introduced blocking in case an event was > reinjected to L2 (commit acc9ab601327 ("KVM: nVMX: Fix pending events > injection")) contains a bug: It returns -EBUSY even if there are no > pending L1 events which requires VMExit from L2 to L1. > > This commit fix this issue. > > Fixes: acc9ab601327 ("KVM: nVMX: Fix pending events injection") > > Signed-off-by: Liran Alon > Reviewed-by: Nikita Leshenko > Signed-off-by: Konrad Rzeszutek Wilk > --- Applied, thanks.