public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 0/2] Lapic LDR fixup
Date: Fri, 17 Nov 2017 19:37:04 +0000	[thread overview]
Message-ID: <20171117193703.GE2421@work-vm> (raw)
In-Reply-To: <56843423-3d23-cb5a-d887-52597e02c241@redhat.com>

* Paolo Bonzini (pbonzini@redhat.com) wrote:
> On 17/11/2017 12:52, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > 
> > In x2apic mode the LDR should be fixed, however
> > it gets overwritten when the lapic state is loaded
> > after a migration.  Change the fixup to keep LDR constant.
> > 
> > Dave
> > 
> > Dr. David Alan Gilbert (2):
> >   KVM: lapic: Split out x2apic ldr calculation
> >   KVM: lapic: Fixup LDR on load in x2apic
> > 
> >  arch/x86/kvm/lapic.c | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> 
> Queued, thanks.

Hang on, there's something not right here.
I've got a Linux guest migration that's unstable with this
patch.
(Tasks blocked for >22seconds, generally memory related, so I'm
wondering if it's IPIs not happening)

I'll get back to you next week.

Dave

> Paolo
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  reply	other threads:[~2017-11-17 19:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 11:52 [PATCH 0/2] Lapic LDR fixup Dr. David Alan Gilbert (git)
2017-11-17 11:52 ` [PATCH 1/2] KVM: lapic: Split out x2apic ldr calculation Dr. David Alan Gilbert (git)
2017-11-23 15:31   ` David Hildenbrand
2017-11-17 11:52 ` [PATCH 2/2] KVM: lapic: Fixup LDR on load in x2apic Dr. David Alan Gilbert (git)
2017-11-17 21:01   ` Liran Alon
2017-11-17 21:03     ` Liran Alon
2017-11-20  0:53       ` Wanpeng Li
2017-11-20  1:04         ` Liran Alon
2017-11-20 20:48           ` Paolo Bonzini
2017-11-20 10:48       ` Dr. David Alan Gilbert
2017-11-17 12:29 ` [PATCH 0/2] Lapic LDR fixup Paolo Bonzini
2017-11-17 19:37   ` Dr. David Alan Gilbert [this message]
2017-11-17 20:27     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171117193703.GE2421@work-vm \
    --to=dgilbert@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox