From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dr. David Alan Gilbert" Subject: Re: [PATCH 0/2] Lapic LDR fixup Date: Fri, 17 Nov 2017 19:37:04 +0000 Message-ID: <20171117193703.GE2421@work-vm> References: <20171117115250.7564-1-dgilbert@redhat.com> <56843423-3d23-cb5a-d887-52597e02c241@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17548 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751102AbdKQThN (ORCPT ); Fri, 17 Nov 2017 14:37:13 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 15A416F5 for ; Fri, 17 Nov 2017 19:37:13 +0000 (UTC) Content-Disposition: inline In-Reply-To: <56843423-3d23-cb5a-d887-52597e02c241@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: * Paolo Bonzini (pbonzini@redhat.com) wrote: > On 17/11/2017 12:52, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > In x2apic mode the LDR should be fixed, however > > it gets overwritten when the lapic state is loaded > > after a migration. Change the fixup to keep LDR constant. > > > > Dave > > > > Dr. David Alan Gilbert (2): > > KVM: lapic: Split out x2apic ldr calculation > > KVM: lapic: Fixup LDR on load in x2apic > > > > arch/x86/kvm/lapic.c | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > Queued, thanks. Hang on, there's something not right here. I've got a Linux guest migration that's unstable with this patch. (Tasks blocked for >22seconds, generally memory related, so I'm wondering if it's IPIs not happening) I'll get back to you next week. Dave > Paolo -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK