From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH 1/3] KVM: Don't enable MWAIT in guest by default
Date: Wed, 29 Nov 2017 17:58:08 +0100
Message-ID: <20171129165808.GB10661@flask>
References: <1511615373-32615-1-git-send-email-jschoenh@amazon.de>
 <1511615373-32615-2-git-send-email-jschoenh@amazon.de>
 <CALMp9eStkpHrmeto_Q4G6_Lby_8dBZAeYKFBcvLHZnKNtQut6g@mail.gmail.com>
 <18389aed-14f9-5103-45c5-c89d14ab8c4d@amazon.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Jim Mattson <jmattson@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        KarimAllah Ahmed <karahmed@amazon.de>,
        kvm list <kvm@vger.kernel.org>
To: Jan =?utf-8?Q?H=2E_Sch=C3=B6nherr?= <jschoenh@amazon.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:52550 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932365AbdK2Q6P (ORCPT <rfc822;kvm@vger.kernel.org>);
        Wed, 29 Nov 2017 11:58:15 -0500
Content-Disposition: inline
In-Reply-To: <18389aed-14f9-5103-45c5-c89d14ab8c4d@amazon.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2017-11-29 00:58+0100, Jan H. Schönherr:
> On 11/27/2017 07:13 PM, Jim Mattson wrote:
> > I don't understand the concern regarding CPUID5_ECX_INTERRUPT_BREAK.
> > Even if the CPU has this feature, can't the guest bypass it by
> > disabling interrupts and invoking MWAIT with bit 0 of ECX clear?
> 
> Note, that there was this series at some point:
> 
>   [PATCH 0/4] KVM: x86: kvm_mwait_in_guest() cleanup and fixes
>   https://www.spinics.net/lists/kvm/msg149238.html
> 
> That throws away most of the function.
> No sure, what happened to that. Radim?

I forgot about that while waiting whether its discussion would continue.
Going to send v2,

thanks.