From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH] KVM: VMX: fix page leak in hardware_setup() Date: Tue, 5 Dec 2017 22:37:58 +0100 Message-ID: <20171205213757.GA17273@flask> References: <20171201175756.16841-1-jmattson@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Jim Mattson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39158 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbdLEViB (ORCPT ); Tue, 5 Dec 2017 16:38:01 -0500 Content-Disposition: inline In-Reply-To: <20171201175756.16841-1-jmattson@google.com> Sender: kvm-owner@vger.kernel.org List-ID: 2017-12-01 09:57-0800, Jim Mattson: > vmx_io_bitmap_b should not be allocated twice. > > Fixes: 23611332938d ("KVM: VMX: refactor setup of global page-sized bitmaps") > Signed-off-by: Jim Mattson > --- Applied, thanks. > arch/x86/kvm/vmx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 4704aaf6d19e..5fb5c4aff1cf 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -6751,7 +6751,6 @@ static __init int hardware_setup(void) > goto out; > } > > - vmx_io_bitmap_b = (unsigned long *)__get_free_page(GFP_KERNEL); > memset(vmx_vmread_bitmap, 0xff, PAGE_SIZE); > memset(vmx_vmwrite_bitmap, 0xff, PAGE_SIZE); > > -- > 2.15.0.531.g2ccb3012c9-goog >