* Re: [PATCH] KVM: VMX: fix page leak in hardware_setup()
2017-12-01 17:57 [PATCH] KVM: VMX: fix page leak in hardware_setup() Jim Mattson
@ 2017-12-01 20:59 ` Krish Sadhukhan
2017-12-04 9:09 ` David Hildenbrand
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Krish Sadhukhan @ 2017-12-01 20:59 UTC (permalink / raw)
To: Jim Mattson, Radim Krčmář, kvm
On 12/01/2017 09:57 AM, Jim Mattson wrote:
> vmx_io_bitmap_b should not be allocated twice.
>
> Fixes: 23611332938d ("KVM: VMX: refactor setup of global page-sized bitmaps")
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---
> arch/x86/kvm/vmx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 4704aaf6d19e..5fb5c4aff1cf 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -6751,7 +6751,6 @@ static __init int hardware_setup(void)
> goto out;
> }
>
> - vmx_io_bitmap_b = (unsigned long *)__get_free_page(GFP_KERNEL);
> memset(vmx_vmread_bitmap, 0xff, PAGE_SIZE);
> memset(vmx_vmwrite_bitmap, 0xff, PAGE_SIZE);
>
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] KVM: VMX: fix page leak in hardware_setup()
2017-12-01 17:57 [PATCH] KVM: VMX: fix page leak in hardware_setup() Jim Mattson
2017-12-01 20:59 ` Krish Sadhukhan
@ 2017-12-04 9:09 ` David Hildenbrand
2017-12-05 21:37 ` Radim Krčmář
2017-12-07 3:57 ` Quan Xu
3 siblings, 0 replies; 5+ messages in thread
From: David Hildenbrand @ 2017-12-04 9:09 UTC (permalink / raw)
To: Jim Mattson, Radim Krčmář, kvm
On 01.12.2017 18:57, Jim Mattson wrote:
> vmx_io_bitmap_b should not be allocated twice.
>
> Fixes: 23611332938d ("KVM: VMX: refactor setup of global page-sized bitmaps")
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---
> arch/x86/kvm/vmx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 4704aaf6d19e..5fb5c4aff1cf 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -6751,7 +6751,6 @@ static __init int hardware_setup(void)
> goto out;
> }
>
> - vmx_io_bitmap_b = (unsigned long *)__get_free_page(GFP_KERNEL);
> memset(vmx_vmread_bitmap, 0xff, PAGE_SIZE);
> memset(vmx_vmwrite_bitmap, 0xff, PAGE_SIZE);
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] KVM: VMX: fix page leak in hardware_setup()
2017-12-01 17:57 [PATCH] KVM: VMX: fix page leak in hardware_setup() Jim Mattson
2017-12-01 20:59 ` Krish Sadhukhan
2017-12-04 9:09 ` David Hildenbrand
@ 2017-12-05 21:37 ` Radim Krčmář
2017-12-07 3:57 ` Quan Xu
3 siblings, 0 replies; 5+ messages in thread
From: Radim Krčmář @ 2017-12-05 21:37 UTC (permalink / raw)
To: Jim Mattson; +Cc: kvm
2017-12-01 09:57-0800, Jim Mattson:
> vmx_io_bitmap_b should not be allocated twice.
>
> Fixes: 23611332938d ("KVM: VMX: refactor setup of global page-sized bitmaps")
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---
Applied, thanks.
> arch/x86/kvm/vmx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 4704aaf6d19e..5fb5c4aff1cf 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -6751,7 +6751,6 @@ static __init int hardware_setup(void)
> goto out;
> }
>
> - vmx_io_bitmap_b = (unsigned long *)__get_free_page(GFP_KERNEL);
> memset(vmx_vmread_bitmap, 0xff, PAGE_SIZE);
> memset(vmx_vmwrite_bitmap, 0xff, PAGE_SIZE);
>
> --
> 2.15.0.531.g2ccb3012c9-goog
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] KVM: VMX: fix page leak in hardware_setup()
2017-12-01 17:57 [PATCH] KVM: VMX: fix page leak in hardware_setup() Jim Mattson
` (2 preceding siblings ...)
2017-12-05 21:37 ` Radim Krčmář
@ 2017-12-07 3:57 ` Quan Xu
3 siblings, 0 replies; 5+ messages in thread
From: Quan Xu @ 2017-12-07 3:57 UTC (permalink / raw)
To: Jim Mattson, Radim Krčmář, kvm
On 2017/12/02 01:57, Jim Mattson wrote:
> vmx_io_bitmap_b should not be allocated twice.
>
> Fixes: 23611332938d ("KVM: VMX: refactor setup of global page-sized bitmaps")
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---
> arch/x86/kvm/vmx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 4704aaf6d19e..5fb5c4aff1cf 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -6751,7 +6751,6 @@ static __init int hardware_setup(void)
> goto out;
> }
>
> - vmx_io_bitmap_b = (unsigned long *)__get_free_page(GFP_KERNEL);
> memset(vmx_vmread_bitmap, 0xff, PAGE_SIZE);
> memset(vmx_vmwrite_bitmap, 0xff, PAGE_SIZE);
>
Reviewed-by: Quan Xu <quan.xu0@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread