From: Stefan Raspl <raspl@linux.vnet.ibm.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, rkrcmar@redhat.com, frankja@linux.vnet.ibm.com
Subject: [PATCH v2 09/11] tools/kvm_stat: stop ignoring unhandled arguments
Date: Mon, 11 Dec 2017 12:25:27 +0100 [thread overview]
Message-ID: <20171211112529.33706-10-raspl@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171211112529.33706-1-raspl@linux.vnet.ibm.com>
From: Stefan Raspl <stefan.raspl@de.ibm.com>
Unhandled arguments, which could easily include typos, are simply
ignored. We should be strict to avoid undetected typos.
To reproduce start kvm_stat with an extra argument, e.g.
'kvm_stat -d bnuh5ol' and note that this will actually work.
Signed-off-by: Stefan Raspl <raspl@linux.vnet.ibm.com>
---
tools/kvm/kvm_stat/kvm_stat | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
index 6ca18d15488e..42c34b8818f7 100755
--- a/tools/kvm/kvm_stat/kvm_stat
+++ b/tools/kvm/kvm_stat/kvm_stat
@@ -1517,7 +1517,9 @@ Press any other key to refresh statistics immediately.
help='restrict statistics to guest by name',
callback=cb_guest_to_pid,
)
- (options, _) = optparser.parse_args(sys.argv)
+ options, ukn = optparser.parse_args(sys.argv)
+ if len(ukn) != 1:
+ sys.exit('Error: Unknown argument(s): ' + ', '.join(ukn[-2:]))
try:
# verify that we were passed a valid regex up front
re.compile(options.fields)
--
2.13.5
next prev parent reply other threads:[~2017-12-11 11:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 11:25 [PATCH v2 00/11] tools/kvm_stat: misc fixes Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 01/11] tools/kvm_stat: fix command line option '-g' Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 02/11] tools/kvm_stat: fix drilldown in events-by-guests mode Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 03/11] tools/kvm_stat: fix missing field update after filter change Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 04/11] tools/kvm_stat: fix extra handling of 'help' with fields filter Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 05/11] tools/kvm_stat: fix child trace events accounting Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 06/11] tools/kvm_stat: add hint on '-f help' to man page Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 07/11] tools/kvm_stat: handle invalid regular expressions Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 08/11] tools/kvm_stat: suppress usage information on command line errors Stefan Raspl
2017-12-12 15:53 ` Paolo Bonzini
2017-12-12 18:09 ` Stefan Raspl
2017-12-11 11:25 ` Stefan Raspl [this message]
2017-12-12 15:56 ` [PATCH v2 09/11] tools/kvm_stat: stop ignoring unhandled arguments Paolo Bonzini
2017-12-12 18:04 ` Stefan Raspl
2017-12-12 18:06 ` Paolo Bonzini
2017-12-11 11:25 ` [PATCH v2 10/11] tools/kvm_stat: sort '-f help' output Stefan Raspl
2017-12-11 12:20 ` Janosch Frank
2017-12-12 11:30 ` Stefan Raspl
2017-12-12 13:59 ` Stefan Raspl
2017-12-12 18:21 ` Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 11/11] tools/kvm_stat: add line for totals Stefan Raspl
2017-12-12 16:00 ` [PATCH v2 00/11] tools/kvm_stat: misc fixes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211112529.33706-10-raspl@linux.vnet.ibm.com \
--to=raspl@linux.vnet.ibm.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox