public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Raspl <raspl@linux.vnet.ibm.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, rkrcmar@redhat.com, frankja@linux.vnet.ibm.com
Subject: [PATCH v2 10/11] tools/kvm_stat: sort '-f help' output
Date: Mon, 11 Dec 2017 12:25:28 +0100	[thread overview]
Message-ID: <20171211112529.33706-11-raspl@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171211112529.33706-1-raspl@linux.vnet.ibm.com>

From: Stefan Raspl <stefan.raspl@de.ibm.com>

Sort the fields returned by specifying '-f help' on the command line.
While at it, simplify the code a bit, indent the output and eliminate an
extra blank line at the beginning.

Signed-off-by: Stefan Raspl <raspl@linux.vnet.ibm.com>
---
 tools/kvm/kvm_stat/kvm_stat | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
index 42c34b8818f7..929c8379d82a 100755
--- a/tools/kvm/kvm_stat/kvm_stat
+++ b/tools/kvm/kvm_stat/kvm_stat
@@ -33,6 +33,7 @@ import resource
 import struct
 import re
 import subprocess
+from sets import Set
 from collections import defaultdict
 
 VMX_EXIT_REASONS = {
@@ -1572,17 +1573,14 @@ def main():
 
     stats = Stats(options)
 
-    if options.fields == "help":
+    if options.fields == 'help':
         stats.fields_filter = None
-        event_list = "\n"
-        s = stats.get()
-        for key in s.keys():
-            if key.find('(') != -1:
-                key = key[0:key.find('(')]
-            if event_list.find('\n' + key + '\n') == -1:
-                event_list += key + '\n'
-        sys.stdout.write(event_list)
-        return ""
+        event_list = []
+        for key in stats.get().keys():
+            event_list.append(key.split('(', 1)[0])
+        event_list.sort()
+        sys.stdout.write('  ' + '\n  '.join(sorted(Set(event_list))) + '\n')
+        sys.exit(0)
 
     if options.log:
         log(stats)
-- 
2.13.5

  parent reply	other threads:[~2017-12-11 11:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 11:25 [PATCH v2 00/11] tools/kvm_stat: misc fixes Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 01/11] tools/kvm_stat: fix command line option '-g' Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 02/11] tools/kvm_stat: fix drilldown in events-by-guests mode Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 03/11] tools/kvm_stat: fix missing field update after filter change Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 04/11] tools/kvm_stat: fix extra handling of 'help' with fields filter Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 05/11] tools/kvm_stat: fix child trace events accounting Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 06/11] tools/kvm_stat: add hint on '-f help' to man page Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 07/11] tools/kvm_stat: handle invalid regular expressions Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 08/11] tools/kvm_stat: suppress usage information on command line errors Stefan Raspl
2017-12-12 15:53   ` Paolo Bonzini
2017-12-12 18:09     ` Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 09/11] tools/kvm_stat: stop ignoring unhandled arguments Stefan Raspl
2017-12-12 15:56   ` Paolo Bonzini
2017-12-12 18:04     ` Stefan Raspl
2017-12-12 18:06       ` Paolo Bonzini
2017-12-11 11:25 ` Stefan Raspl [this message]
2017-12-11 12:20   ` [PATCH v2 10/11] tools/kvm_stat: sort '-f help' output Janosch Frank
2017-12-12 11:30     ` Stefan Raspl
2017-12-12 13:59     ` Stefan Raspl
2017-12-12 18:21     ` Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 11/11] tools/kvm_stat: add line for totals Stefan Raspl
2017-12-12 16:00 ` [PATCH v2 00/11] tools/kvm_stat: misc fixes Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171211112529.33706-11-raspl@linux.vnet.ibm.com \
    --to=raspl@linux.vnet.ibm.com \
    --cc=frankja@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox