Re: [PATCH v2 10/11] tools/kvm_stat: sort '-f help' output

Stefan Raspl
2017-12-12T13:59:39Z

On 11.12.2017 13:20, Janosch Frank wrote:
> On 11.12.2017 12:25, Stefan Raspl wrote:
>> diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
>> index 42c34b8818f7..929c8379d82a 100755
>> --- a/tools/kvm/kvm_stat/kvm_stat
>> +++ b/tools/kvm/kvm_stat/kvm_stat
>> @@ -33,6 +33,7 @@ import resource
>> import struct
>> import re
>> import subprocess
>> +from sets import Set
>
> What's the reason for this import, shouldn't set be built in from at
> least 2.7 on? It even seems to be 2.4. The module should be deprecated
> from 2.6 on.
>
>> + event_list.sort()
>> + sys.stdout.write(' ' + '\n '.join(sorted(Set(event_list))) + '\n')

Ah, now I know what mean: Use the built-in 'set' instead of 'Set'?
Yup, good point, will do.

Ciao,
Stefan