public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	christoffer.dall@linaro.org, James Hogan <jhogan@kernel.org>,
	Paul Mackerras <paulus@ozlabs.org>,
	Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH v2] KVM: introduce kvm_arch_vcpu_async_ioctl
Date: Wed, 13 Dec 2017 10:41:39 +0100	[thread overview]
Message-ID: <20171213104139.65396b1c.cohuck@redhat.com> (raw)
In-Reply-To: <1513157757-1917-1-git-send-email-pbonzini@redhat.com>

On Wed, 13 Dec 2017 10:35:57 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:

> After the vcpu_load/vcpu_put pushdown, the handling of asynchronous VCPU
> ioctl is already much clearer in that it is obvious that they bypass
> vcpu_load and vcpu_put.
> 
> However, it is still not perfect in that the different state of the VCPU
> mutex is still hidden in the caller.  Separate those ioctls into a new
> function kvm_arch_vcpu_async_ioctl that returns -ENOIOCTLCMD for more
> "traditional" synchronous ioctls.
> 
> Cc: James Hogan <jhogan@kernel.org>
> Cc: Paul Mackerras <paulus@ozlabs.org>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> Suggested-by: Cornelia Huck <cohuck@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  arch/mips/kvm/Kconfig      |  1 +
>  arch/mips/kvm/mips.c       | 15 ++++++++++++---
>  arch/powerpc/kvm/Kconfig   |  1 +
>  arch/powerpc/kvm/powerpc.c | 14 +++++++++++---
>  arch/s390/kvm/Kconfig      |  1 +
>  arch/s390/kvm/kvm-s390.c   | 16 ++++++++++++----
>  include/linux/kvm_host.h   | 11 +++++++++++
>  virt/kvm/kvm_main.c        | 12 +++++-------
>  8 files changed, 54 insertions(+), 17 deletions(-)

Using HAVE_KVM_VCPU_ASYNC_IOCTL looks good to me.

  reply	other threads:[~2017-12-13  9:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13  9:35 [PATCH v2] KVM: introduce kvm_arch_vcpu_async_ioctl Paolo Bonzini
2017-12-13  9:41 ` Cornelia Huck [this message]
2017-12-13 10:17 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171213104139.65396b1c.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=christoffer.dall@linaro.org \
    --cc=jhogan@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@ozlabs.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox