From: Alex Williamson <alex.williamson@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH kernel] vfio-pci: Mask INTx if a device is not capabable of enabling it
Date: Wed, 20 Dec 2017 12:02:27 -0700 [thread overview]
Message-ID: <20171220120227.365fb6fd@t450s.home> (raw)
In-Reply-To: <20171207015654.5982-1-aik@ozlabs.ru>
On Thu, 7 Dec 2017 12:56:54 +1100
Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> At the moment VFIO rightfully assumes that INTx is supported if
> the interrupt pin is not set to zero in the device config space.
> However if that is not the case (the pin is not zero but pdev->irq is),
> vfio_intx_enable() fails.
>
> In order to prevent the userspace from trying to enable INTx when we know
> that it cannot work, let's mask the PCI_INTERRUPT_PIN register.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> drivers/vfio/pci/vfio_pci.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied to v4.16/vfio. Thanks,
Alex
prev parent reply other threads:[~2017-12-20 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 1:56 [PATCH kernel] vfio-pci: Mask INTx if a device is not capabable of enabling it Alexey Kardashevskiy
2017-12-20 19:02 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220120227.365fb6fd@t450s.home \
--to=alex.williamson@redhat.com \
--cc=aik@ozlabs.ru \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox