From: Christoffer Dall <christoffer.dall@linaro.org>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, cdall@linaro.org, pbonzini@redhat.com,
rkrcmar@redhat.com
Subject: Re: [PATCH kvm-unit-tests] arm/arm64: fix gicv3-active test
Date: Tue, 9 Jan 2018 20:10:33 +0100 [thread overview]
Message-ID: <20180109191033.GE15307@cbox> (raw)
In-Reply-To: <20180109185429.3654-1-drjones@redhat.com>
On Tue, Jan 09, 2018 at 07:54:29PM +0100, Andrew Jones wrote:
> GICR_ICACTIVER0 (aka GICD_ICACTIVER) is based of the SGI_base,
> not the RD_base.
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> arm/gic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arm/gic.c b/arm/gic.c
> index a945f7ab8385..5dd958e8b66b 100644
> --- a/arm/gic.c
> +++ b/arm/gic.c
> @@ -274,7 +274,7 @@ static void ipi_clear_active_handler(struct pt_regs *regs __unused)
> if (gic_version() == 2)
> base = gicv2_dist_base();
> else
> - base = gicv3_redist_base();
> + base = gicv3_sgi_base();
Shouldn't this be:
if (gic_version() == 2)
base = gicv2_dist_base();
else if (irqnr < GIC_NR_PRIVATE_IRQS)
base = gicv3_sgi_base();
else
base = gicv3_dist_base();
Which would support all IRQs ?
Thanks,
-Christoffer
>
> writel(val, base + GICD_ICACTIVER);
>
> --
> 2.13.6
>
next prev parent reply other threads:[~2018-01-09 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 18:54 [PATCH kvm-unit-tests] arm/arm64: fix gicv3-active test Andrew Jones
2018-01-09 19:10 ` Christoffer Dall [this message]
2018-01-10 8:39 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109191033.GE15307@cbox \
--to=christoffer.dall@linaro.org \
--cc=cdall@linaro.org \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox