From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH kvm-unit-tests] arm/arm64: fix gicv3-active test Date: Tue, 9 Jan 2018 20:10:33 +0100 Message-ID: <20180109191033.GE15307@cbox> References: <20180109185429.3654-1-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, cdall@linaro.org, pbonzini@redhat.com, rkrcmar@redhat.com To: Andrew Jones Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:45026 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933031AbeAITKg (ORCPT ); Tue, 9 Jan 2018 14:10:36 -0500 Received: by mail-wm0-f68.google.com with SMTP id t8so22332318wmc.3 for ; Tue, 09 Jan 2018 11:10:35 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180109185429.3654-1-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jan 09, 2018 at 07:54:29PM +0100, Andrew Jones wrote: > GICR_ICACTIVER0 (aka GICD_ICACTIVER) is based of the SGI_base, > not the RD_base. > > Signed-off-by: Andrew Jones > --- > arm/gic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arm/gic.c b/arm/gic.c > index a945f7ab8385..5dd958e8b66b 100644 > --- a/arm/gic.c > +++ b/arm/gic.c > @@ -274,7 +274,7 @@ static void ipi_clear_active_handler(struct pt_regs *regs __unused) > if (gic_version() == 2) > base = gicv2_dist_base(); > else > - base = gicv3_redist_base(); > + base = gicv3_sgi_base(); Shouldn't this be: if (gic_version() == 2) base = gicv2_dist_base(); else if (irqnr < GIC_NR_PRIVATE_IRQS) base = gicv3_sgi_base(); else base = gicv3_dist_base(); Which would support all IRQs ? Thanks, -Christoffer > > writel(val, base + GICD_ICACTIVER); > > -- > 2.13.6 >