From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [PATCH v4 11/19] KVM: arm/arm64: Demote HYP VA range display to
 being a debug feature
Date: Mon, 15 Jan 2018 16:54:59 +0100
Message-ID: <20180115155459.GM21403@cbox>
References: <20180104184334.16571-1-marc.zyngier@arm.com>
 <20180104184334.16571-12-marc.zyngier@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
        kvmarm@lists.cs.columbia.edu, Mark Rutland <mark.rutland@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        James Morse <james.morse@arm.com>,
        Steve Capper <steve.capper@arm.com>,
        Peter Maydell <peter.maydell@linaro.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wm0-f67.google.com ([74.125.82.67]:36915 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933054AbeAOPzC (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 15 Jan 2018 10:55:02 -0500
Received: by mail-wm0-f67.google.com with SMTP id v71so2932515wmv.2
        for <kvm@vger.kernel.org>; Mon, 15 Jan 2018 07:55:02 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20180104184334.16571-12-marc.zyngier@arm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Jan 04, 2018 at 06:43:26PM +0000, Marc Zyngier wrote:
> Displaying the HYP VA information is slightly counterproductive when
> using VA randomization. Turn it into a debug feature only, and adjust
> the last displayed value to reflect the top of RAM instead of ~0.
> 
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

Acked-by: Christoffer Dall <christoffer.dall@linaro.org>

> ---
>  virt/kvm/arm/mmu.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c
> index b4b69c2d1012..84d09f1a44d4 100644
> --- a/virt/kvm/arm/mmu.c
> +++ b/virt/kvm/arm/mmu.c
> @@ -1760,9 +1760,10 @@ int kvm_mmu_init(void)
>  	 */
>  	BUG_ON((hyp_idmap_start ^ (hyp_idmap_end - 1)) & PAGE_MASK);
>  
> -	kvm_info("IDMAP page: %lx\n", hyp_idmap_start);
> -	kvm_info("HYP VA range: %lx:%lx\n",
> -		 kern_hyp_va(PAGE_OFFSET), kern_hyp_va(~0UL));
> +	kvm_debug("IDMAP page: %lx\n", hyp_idmap_start);
> +	kvm_debug("HYP VA range: %lx:%lx\n",
> +		  kern_hyp_va(PAGE_OFFSET),
> +		  kern_hyp_va((unsigned long)high_memory - 1));
>  
>  	if (hyp_idmap_start >= kern_hyp_va(PAGE_OFFSET) &&
>  	    hyp_idmap_start <  kern_hyp_va(~0UL) &&
> -- 
> 2.14.2
>