From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Schwidefsky Subject: Re: [RFC/PATCH v2 11/22] s390/mm: Remove superfluous parameter Date: Mon, 22 Jan 2018 14:24:37 +0100 Message-ID: <20180122142437.18f390a0@mschwideX1> References: <1513169613-13509-1-git-send-email-frankja@linux.vnet.ibm.com> <1513169613-13509-12-git-send-email-frankja@linux.vnet.ibm.com> <46e78910-6ea8-d384-df68-80b9e7fe0f6c@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Janosch Frank , kvm@vger.kernel.org, david@redhat.com, dominik.dingel@gmail.com, linux-s390@vger.kernel.org To: Christian Borntraeger Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:54604 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751086AbeAVNYp (ORCPT ); Mon, 22 Jan 2018 08:24:45 -0500 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0MDOLMn018046 for ; Mon, 22 Jan 2018 08:24:44 -0500 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0b-001b2d01.pphosted.com with ESMTP id 2fnc23vg1p-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 22 Jan 2018 08:24:44 -0500 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 22 Jan 2018 13:24:42 -0000 In-Reply-To: <46e78910-6ea8-d384-df68-80b9e7fe0f6c@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 22 Jan 2018 14:14:56 +0100 Christian Borntraeger wrote: Yes, please take this via the kvm tree. > thanks applied. > Martin unless you have concerns I will take this via the kvm tree. > > On 12/13/2017 01:53 PM, Janosch Frank wrote: > > It seems it hasn't even been used before the last cleanup and was > > overlooked. > > > > Signed-off-by: Janosch Frank > > --- > > arch/s390/mm/gmap.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c > > index ffc11d8..d396da8 100644 > > --- a/arch/s390/mm/gmap.c > > +++ b/arch/s390/mm/gmap.c > > @@ -2237,7 +2237,7 @@ EXPORT_SYMBOL_GPL(gmap_shadow_page); > > * Called with sg->parent->shadow_lock. > > */ > > static void gmap_shadow_notify(struct gmap *sg, unsigned long vmaddr, > > - unsigned long gaddr, pte_t *pte) > > + unsigned long gaddr) > > { > > struct gmap_rmap *rmap, *rnext, *head; > > unsigned long start, end, bits, raddr; > > @@ -2322,7 +2322,7 @@ void ptep_notify(struct mm_struct *mm, unsigned long vmaddr, > > spin_lock(&gmap->shadow_lock); > > list_for_each_entry_safe(sg, next, > > &gmap->children, list) > > - gmap_shadow_notify(sg, vmaddr, gaddr, pte); > > + gmap_shadow_notify(sg, vmaddr, gaddr); > > spin_unlock(&gmap->shadow_lock); > > } > > if (bits & PGSTE_IN_BIT) > > -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.