From: Cornelia Huck <cohuck@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: David Hildenbrand <david@redhat.com>, KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Janosch Frank <frankja@linux.vnet.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Michael Mueller <mimu@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 06/12] KVM: s390: exploit GISA and AIV for emulated interrupts
Date: Thu, 25 Jan 2018 17:39:53 +0100 [thread overview]
Message-ID: <20180125173953.302fd88e.cohuck@redhat.com> (raw)
In-Reply-To: <b7fb3580-0eae-ee29-cae6-d58bc8a4e350@de.ibm.com>
On Thu, 25 Jan 2018 17:32:29 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> On 01/25/2018 03:20 PM, David Hildenbrand wrote:
> [...]
> >> @@ -918,18 +919,38 @@ static int __must_check __deliver_virtio(struct kvm_vcpu *vcpu)
> >> return rc ? -EFAULT : 0;
> >> }
> >>
> >> +static int __do_deliver_io(struct kvm_vcpu *vcpu, struct kvm_s390_io_info *io)
> >> +{
> >> + int rc;
> >> +
> >> + rc = put_guest_lc(vcpu, io->subchannel_id, (u16 *)__LC_SUBCHANNEL_ID);
> >> + rc |= put_guest_lc(vcpu, io->subchannel_nr, (u16 *)__LC_SUBCHANNEL_NR);
> >> + rc |= put_guest_lc(vcpu, io->io_int_parm, (u32 *)__LC_IO_INT_PARM);
> >> + rc |= put_guest_lc(vcpu, io->io_int_word, (u32 *)__LC_IO_INT_WORD);
> >> + rc |= write_guest_lc(vcpu, __LC_IO_OLD_PSW,
> >> + &vcpu->arch.sie_block->gpsw,
> >> + sizeof(psw_t));
> >> + rc |= read_guest_lc(vcpu, __LC_IO_NEW_PSW,
> >> + &vcpu->arch.sie_block->gpsw,
> >> + sizeof(psw_t));
> >
> > These should now it into less lines.
>
> The last two lines are way beyond 80.
>
> Can you factor that change out into
> > a separate patch?
>
>
> Unless Conny agrees that this is absolutely mandatory I would like to avoid that.
I don't think factoring this out would be very useful.
next prev parent reply other threads:[~2018-01-25 16:39 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 13:28 [PATCH v2 00/12] KVM: s390: exitless interrupt support for KVM Christian Borntraeger
2018-01-25 13:28 ` [PATCH v2 01/12] KVM: s390: reverse bit ordering of irqs in pending mask Christian Borntraeger
2018-01-25 13:59 ` David Hildenbrand
2018-01-25 13:28 ` [PATCH v2 02/12] KVM: s390: define GISA format-0 data structure Christian Borntraeger
2018-01-25 14:00 ` David Hildenbrand
2018-01-26 9:03 ` Cornelia Huck
2018-01-25 13:28 ` [PATCH v2 03/12] s390/bitops: add test_and_clear_bit_inv() Christian Borntraeger
2018-01-25 13:53 ` Martin Schwidefsky
2018-01-25 13:28 ` [PATCH v2 04/12] KVM: s390: implement GISA IPM related primitives Christian Borntraeger
2018-01-25 14:06 ` David Hildenbrand
2018-01-25 14:21 ` Christian Borntraeger
2018-01-25 13:28 ` [PATCH v2 05/12] s390/css: indicate the availability of the AIV facility Christian Borntraeger
2018-01-25 13:54 ` Martin Schwidefsky
2018-01-25 13:59 ` David Hildenbrand
2018-01-25 13:28 ` [PATCH v2 06/12] KVM: s390: exploit GISA and AIV for emulated interrupts Christian Borntraeger
2018-01-25 14:20 ` David Hildenbrand
2018-01-25 14:32 ` Christian Borntraeger
2018-01-25 14:42 ` David Hildenbrand
2018-01-25 14:45 ` Christian Borntraeger
2018-01-25 15:05 ` Cornelia Huck
2018-01-25 15:27 ` David Hildenbrand
2018-01-25 15:31 ` Christian Borntraeger
2018-01-25 16:32 ` Christian Borntraeger
2018-01-25 16:39 ` Cornelia Huck [this message]
2018-01-25 16:47 ` David Hildenbrand
2018-01-25 16:50 ` Christian Borntraeger
2018-01-25 13:28 ` [PATCH v2 07/12] KVM: s390: abstract adapter interruption word generation from ISC Christian Borntraeger
2018-01-25 13:28 ` [PATCH v2 08/12] KVM: s390: add GISA interrupts to FLIC ioctl interface Christian Borntraeger
2018-01-26 9:18 ` Cornelia Huck
2018-01-25 13:28 ` [PATCH v2 09/12] KVM: s390: make kvm_s390_get_io_int() aware of GISA Christian Borntraeger
2018-01-26 9:41 ` Cornelia Huck
2018-01-26 9:57 ` Christian Borntraeger
2018-01-26 11:21 ` Cornelia Huck
2018-01-26 11:25 ` Christian Borntraeger
2018-01-26 11:40 ` Cornelia Huck
2018-01-26 13:13 ` Christian Borntraeger
2018-01-25 13:28 ` [PATCH v2 10/12] KVM: s390: activate GISA for emulated interrupts Christian Borntraeger
2018-01-25 13:28 ` [PATCH v2 11/12] s390/sclp: expose the GISA format facility Christian Borntraeger
2018-01-25 13:54 ` Martin Schwidefsky
2018-01-26 9:44 ` Cornelia Huck
2018-01-25 13:28 ` [PATCH v2 12/12] KVM: s390: introduce the format-1 GISA Christian Borntraeger
2018-01-25 15:31 ` David Hildenbrand
2018-01-25 15:43 ` Christian Borntraeger
2018-01-25 15:47 ` Cornelia Huck
2018-01-25 16:12 ` Christian Borntraeger
2018-01-25 16:17 ` Cornelia Huck
2018-01-25 16:51 ` Christian Borntraeger
2018-01-25 16:53 ` Cornelia Huck
2018-01-25 16:16 ` David Hildenbrand
2018-01-25 16:46 ` Christian Borntraeger
2018-01-26 9:46 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125173953.302fd88e.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mimu@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox