From: "Michael S. Tsirkin" <mst@redhat.com>
To: nilal@redhat.com
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, pagupta@redhat.com,
wei.w.wang@intel.com, yang.zhang.wz@gmail.com, riel@redhat.com,
david@redhat.com, dodgen@google.com, konrad.wilk@oracle.com
Subject: Re: [Patch v6 0/7] KVM: Guest page hinting
Date: Thu, 25 Jan 2018 19:28:50 +0200 [thread overview]
Message-ID: <20180125192731-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20171201173136.849-1-nilal@redhat.com>
On Fri, Dec 01, 2017 at 12:31:29PM -0500, nilal@redhat.com wrote:
> Changelog in v6:
> -Moved CONFIG_KVM_FREE_PAGE_HINTING from virt/kvm/Kconfig to arch/x86/kvm/Kconfig in order to resolve conflicts with other architectures:
> *s390 has its own page hinting functionality
> *powerpc has its own arch_free_page implementation
> -Fixed the typo in virtio_balloon structure which caused compilation issues when guest page hinting was disabled
> -Separated init_vqs implementation with and without hinting_vq enablement based on the CONFIG_KVM_FREE_PAGE_HINTING ifdef
>
> Virtio interface changes are picked up from Wei's patch-set for Virtio-balloon enhancement[3]. "Wei, How would you like me to credit you in the final patch?")
So the main point missing in all this is any kind of performance
numbers: what kind of gain do you see with these patches and for which
workloads? What kind of overhead and for which workloads?
--
MST
prev parent reply other threads:[~2018-01-25 17:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 17:31 [Patch v6 0/7] KVM: Guest page hinting nilal
2017-12-01 17:31 ` [Patch v6 1/7] KVM: Support for guest " nilal
2017-12-01 17:31 ` [Patch v6 2/7] KVM: Guest page hinting functionality nilal
2017-12-01 17:31 ` [Patch v6 3/7] KVM: Adding tracepoints for guest page hinting nilal
2017-12-01 17:31 ` [Patch v6 4/7] virtio: Exposes added descriptor to the other side synchronously nilal
2017-12-01 17:31 ` [Patch v6 5/7] KVM: Sending hyperlist to the host via hinting_vq nilal
2017-12-01 17:31 ` [Patch v6 6/7] KVM: Enabling guest page hinting via static key nilal
2017-12-01 17:31 ` [Patch v6 7/7] KVM: Disabling page poisoning to avoid memory corruption errors nilal
2017-12-01 17:32 ` [QEMU PATCH] kvm: Support for guest page hinting nilal
2018-01-25 17:28 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125192731-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=david@redhat.com \
--cc=dodgen@google.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=nilal@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=riel@redhat.com \
--cc=wei.w.wang@intel.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).