From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Habkost Subject: Re: [RFC,05/10] x86/speculation: Add basic IBRS support infrastructure Date: Wed, 31 Jan 2018 12:44:41 -0200 Message-ID: <20180131144441.GK26425@localhost.localdomain> References: <1517259759.18619.38.camel@infradead.org> <20180130204623.583b1a7a@alans-desktop> <200C59E8-80F3-4FEC-BA3B-E6A56FA12C74@dinechin.org> <20180131110406.GB2521@work-vm> <20180131115211.2cxz2xj6elv37p6t@pd.tnic> <20180131123036.GD2521@work-vm> <20180131131834.jzown5pteqzd3xmg@pd.tnic> <20180131140449.GF2521@work-vm> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Borislav Petkov , Thomas Gleixner , Christophe de Dinechin , Alan Cox , Linus Torvalds , David Woodhouse , Arjan van de Ven , KarimAllah Ahmed , Linux Kernel Mailing List , Andi Kleen , Andrea Arcangeli , Andy Lutomirski , Ashok Raj , Asit Mallick , Dan Williams , Dave Hansen , Greg Kroah-Hartman , "H . Peter Anvin" , Ingo Molnar , To: "Dr. David Alan Gilbert" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56574 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753571AbeAaOon (ORCPT ); Wed, 31 Jan 2018 09:44:43 -0500 Content-Disposition: inline In-Reply-To: <20180131140449.GF2521@work-vm> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jan 31, 2018 at 02:04:49PM +0000, Dr. David Alan Gilbert wrote: > * Borislav Petkov (bp@suse.de) wrote: > > On Wed, Jan 31, 2018 at 12:30:36PM +0000, Dr. David Alan Gilbert wrote: > > > Indeed, it's only for this weird case where you suddenly need to change > > > it. > > > > No, there's more: > > > > .name = "Broadwell-noTSX", > > .name = "Haswell-noTSX", > > Haswell came out and we made the CPU definition, and then got a > microcode update that removed the feature. > > So the common feature of noTSX and IBRS is that they're the only two > cases where a CPU has released and then the flags have changed later. Also, if anybody don't like it, users can already specify, e.g., "Broadwell,-hle,-rtm" or "Skylake,+spec_ctrl". QEMU only adds have the -noTSX and -IBRS CPU for convenience of management systems that don't know how to check/configure individual CPU features. We're working with libvirt and OpenStack folks to make this kind of trick unnecessary. -- Eduardo