From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ken Hofsass Subject: [PATCH v4 1/2] KVM: x86: add SYNC_REGS_SIZE_BYTES #define. Date: Wed, 31 Jan 2018 16:03:35 -0800 Message-ID: <20180201000336.154170-2-hofsass@google.com> References: <20180201000336.154170-1-hofsass@google.com> Cc: pbonzini@redhat.com, david@redhat.com, jmattson@google.com, Ken Hofsass To: kvm@vger.kernel.org Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:40594 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753671AbeBAAD7 (ORCPT ); Wed, 31 Jan 2018 19:03:59 -0500 Received: by mail-pg0-f67.google.com with SMTP id g16so11426200pgn.7 for ; Wed, 31 Jan 2018 16:03:59 -0800 (PST) In-Reply-To: <20180201000336.154170-1-hofsass@google.com> Sender: kvm-owner@vger.kernel.org List-ID: Replace hardcoded padding size value for struct kvm_sync_regs with #define SYNC_REGS_SIZE_BYTES. Also update the value specified in api.txt from outdated hardcoded value to SYNC_REGS_SIZE_BYTES. Signed-off-by: Ken Hofsass Reviewed-by: David Hildenbrand Acked-by: Christian Borntraeger --- Documentation/virtual/kvm/api.txt | 2 +- include/uapi/linux/kvm.h | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt index e5f1743e0b3e..de55fe173afe 100644 --- a/Documentation/virtual/kvm/api.txt +++ b/Documentation/virtual/kvm/api.txt @@ -3809,7 +3809,7 @@ in userspace. __u64 kvm_dirty_regs; union { struct kvm_sync_regs regs; - char padding[1024]; + char padding[SYNC_REGS_SIZE_BYTES]; } s; If KVM_CAP_SYNC_REGS is defined, these fields allow userspace to access diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h index 62c564dd4aa1..e88ed6325e0e 100644 --- a/include/uapi/linux/kvm.h +++ b/include/uapi/linux/kvm.h @@ -396,6 +396,10 @@ struct kvm_run { char padding[256]; }; + /* 2048 is the size of the char array used to bound/pad the size + * of the union that holds sync regs. + */ + #define SYNC_REGS_SIZE_BYTES 2048 /* * shared registers between kvm and userspace. * kvm_valid_regs specifies the register classes set by the host @@ -407,7 +411,7 @@ struct kvm_run { __u64 kvm_dirty_regs; union { struct kvm_sync_regs regs; - char padding[2048]; + char padding[SYNC_REGS_SIZE_BYTES]; } s; }; -- 2.16.0.rc1.238.g530d649a79-goog