From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH] KVM: x86: Reduce retpoline performance impact in slot_handle_level_range() Date: Fri, 2 Feb 2018 21:23:33 +0000 Message-ID: <20180202212321.5186c13c@alans-desktop> References: <1517583559-424-1-git-send-email-dwmw@amazon.co.uk> <1517599033.31953.71.camel@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Linus Torvalds , Thomas Gleixner , KarimAllah Ahmed , sironi@amazon.de, the arch/x86 maintainers , KVM list , Paolo Bonzini , Linux Kernel Mailing List , Borislav Petkov , Peter Zijlstra To: David Woodhouse Return-path: In-Reply-To: <1517599033.31953.71.camel@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org > Either way, that does look like a reasonable answer. I had looked at > the various one-line wrappers around slot_handle_level_range() and > thought "hm, those should be inline", but I hadn't made the next step > and pondered putting the whole thing inline. We'll give it a spin and > work out where the next performance bottleneck is. Thanks. In addition the problem with switch() is that gcc might decide in some cases that the best way to implement your switch is an indirect call from a lookup table. For the simple case how about wrapping the if into call_likely(foo->bar, usualfunction, args) as a companion to foo->bar(args) that can resolve to nothing special on architectures that don't need it, an if/else case on platforms with spectre, and potentially clever stuff on any platform where you can beat the compiler by knowing probabilities it can't infer ? Alan